https://bugzilla.redhat.com/show_bug.cgi?id=2272134 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |ngompa13@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- In my initial review, I did find a serious issue: the "GPL-3.0" license identifier needs to be clarified. It looks like the sources indicate the codebase is GPLv3, but there is a complete lack of identifying marks about whether it's GPL-3.0-only or GPL-3.0-or-later. The license default is "GPL-3.0-or-later", but I recommend contacting upstream to make a decision on indicating this somehow. The GNU licenses recommend some kind of license header on source files, and I would say that's probably the right thing to do too. I suspect this is necessary for all COSMIC projects. Here's a suggested header template (from some projects I've seen): /* This file is part of {project}. * * Copyright System76, Inc. * * Licensed under the GNU General Public License Version 3 * Fedora-License-Identifier: GPLv3+ * SPDX-2.0-License-Identifier: GPL-3.0+ * SPDX-3.0-License-Identifier: GPL-3.0-or-later * * {project} is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * {project} is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with {project}. If not, see <https://www.gnu.org/licenses/>. */ An simpler alternative that can work is something like this: /* * This file is part of {project} * Copyright System76, Inc. * * Fedora-License-Identifier: GPLv3+ * SPDX-2.0-License-Identifier: GPL-3.0+ * SPDX-3.0-License-Identifier: GPL-3.0-or-later * * This program is free software. * For more information on the license, see LICENSE.md. * For more information on free software, see <https://www.gnu.org/philosophy/free-sw.en.html>. */ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2272134 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272134%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
