[Bug 2294718] Review Request: yudit - Unicode Text Editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2294718



--- Comment #16 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Dr Anirban Mitra from comment #15)
> I tried to implement most of your suggestions as far as I could. However, I
> am unable to remove debuginfo {nil} as it leads to build failure with
> message "error: Empty %files file
> /builddir/build/BUILD/yudit-3.1.0/debugsourcefiles.list"

The binary is being stripped as it is installed.  I see this in the build log:

/builddir/build/BUILD/yudit-3.1.0-build/yudit-3.1.0/bin/install-sh -c -s
uniprint /builddir/build/BUILD/yudit-3.1.0-build/BUILDROOT//usr/bin

The -s argument says to run the strip program.  There are several ways you
could fix this.  For example, you could remove the -s argument in %prep like
this:

sed -i '/install-sh/s/ -s//' Makefile.conf.in

>   I also could not remove  File listed twice: both in data folder of main
> package, and yudit-data subpackage (Please see build log
> athttps://download.copr.fedorainfracloud.org/results/mitradranirban/yudit/
> fedora-40-x86_64/07788320-yudit/builder-live.log.gz 
> Any help regarding these issues will be highly appreciated.

That is because "%files data" contains this:

%{_datadir}/yudit

The yudit-data package therefore owns /usr/share/yudit, *and everything below
it*.  Add "%dir" to the beginning of that line to remove the warning.  Doing so
will reveal that no package owns %{_datadir}/yudit/fonts.

Also, I see that "%description data" now contains "Requires:
hicolor-icon-theme".  That needs to be in "%package data" instead.  In its
current location, it merely shows up as text in the description of the
yudit-data package.

The Fedora project is trying to move away from 32-bit x86 builds.  If you don't
need such a build, then I encourage you to add something like this to the
package:

# See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
ExcludeArch:    %{ix86}

Finally, I fear I pushed you too far towards longer lines.  Now we are getting
rpmlint warnings about %description lines that are too long.  That triggers if
a line is more than 79 characters long.  Can you rewrap to 79 characters or
less?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2294718

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294718%23c16

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux