https://bugzilla.redhat.com/show_bug.cgi?id=2295820 --- Comment #14 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Tim Flink from comment #13) > (In reply to Tom Rix from comment #11) > > (In reply to Tim Flink from comment #6) > > > (In reply to Jeremy Newton from comment #3) > > <snip> > > > I will replace bundled: with a strongly worded comment :P > > eh, now that I'm re-reading this today and looking into it more, I just > misunderstood what bundled(<libname>) does. For some reason, I thought it > would show up as a regular provides and someone could install it instead of > Tensile by accident. I withdraw my concern, it's not worth worrying about > for now and we can deal with any Tensile replacement if/when it ever happens. Then i will keep my strongly worded comment and add bundled: back. > > (In reply to Tom Rix from comment #10) > > (In reply to Tim Flink from comment #2) > > > Overall, it looks good to me but there are 2 bigger things I'm concerned > > > about: > > > 1. Do the files in tensilite/Tensile/CustomKernels/ count as pre-generated > > > code or content? > > > - Is it possible to delete the CustomKernels directory and still build > > > for gfx941 and gfx942 albeit with a less optimized setup? If so, I'd lean > > > more towards content > > > > No it does not build when the kernels are removed. > > Did we ever find an answer to what we can do about these kinds of binary > files and whether they're package-able? I remember it coming up with miopen > but I don't remember what the conclusion was. The review went through, so I > assume that it was determined to be kosher-enough? You asked for them to be removed, I removed them. this crippled miopen optimizations. Now it is on Fedora to regenerate the results which needs hardware to do that. Fedora does not have this hw. Eventually someone will notice and ask for it to be put back. So I would rather not do the same other places. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
