https://bugzilla.redhat.com/show_bug.cgi?id=2293503 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Arthur Bols from comment #3) > Overall looks good, small issues below. :) > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > > - Omitting the first argument of %{pypi_source} is deprecated > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pypi_source Done. > - License file is included in %{pyproject_files}, so you may omit the > %license > field. However, please add `-l` to %{pyproject_save_files} which forces the > check for a license file. > > You can remove: > > %license LICENSE.txt > > Change: > > %pyproject_save_files pygments_lexer_solidity > > Into: > > %pyproject_save_files -l pygments_lexer_solidity Done. New package: Spec URL: https://peter.fedorapeople.org/packages/python-pygments-lexer-solidity.spec SRPM URL: https://peter.fedorapeople.org/packages/python-pygments-lexer-solidity-0.7.0-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293503 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293503%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
