[Bug 2299712] Review Request: uv - An extremely fast Python package installer and resolver, written in Rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2299712



--- Comment #12 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Adjusted so that Patch100-Patch199 are automatically applied for Source1,
Patch200-299 for Source2, and so on.

----------

Expanded and clarified the justification for
0001-Downstream-only-do-not-override-the-default-allocato.patch.

----------

Fixed extra spaces after two emojis in the description. I blame working via SSH
from a MacOS terminal, which doesn’t give those two emojis enough width.

(I am not especially attached to the emojis, but I default to keeping the
description very close to the upstream one, and upstream really likes their
emojis!)

----------

Added

# https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
ExcludeArch:    %{ix86}

and therefore removed

%if 0%{?__isa_bits} == 32
# These tests check zip64 support with files >4GiB, which doesn’t work on
# 32-bit platforms because the file size doesn’t fit in a usize.
mv crates/async_zip/src/tests/write/zip64/mod.rs{,.disabled}
sed -r -i 's@^mod zip64;@// &@' crates/async_zip/src/tests/write/mod.rs
%endif

----------

Removed

export RUSTFLAGS='%{build_rustflags}'

with the understanding that I will need to add

%set_build_flags
export RUSTFLAGS='%{build_rustflags}'

if I do backport this to EPEL9.

I’m happy to let a hypothetical epel9 branch diverge from Fedora and follow a
cherry-picking workflow, but we can cross that bridge if/when we get there.

----------

Adjusted the Summary for python3-uv to "Importable Python module for uv".

----------

Adjusted

# -p uv-auth --lib:

to

# cargo test -p uv-auth --lib:

in the hopes that the meaning will be a little more clear without making the
comment too verbose.

----------

I did NOT:

- drop ", written in Rust" from the main summary: I see and somewhat agree with
both arguments, and for now I’ve chosen to stay closer to upstream
- drop the emojis from the descriptions: as noted, I am not too attached to
them, but everything in Fedora should be fully Unicode-safe, and they are part
of upstream’s communication style
- adjust the style of the License expression: I am still prepared to consider
suggestions for improving this

----------

I do plan to add a uv.rpmlintrc file on import.

----------

I will take some time to audit the bundling pointed out in
https://bugzilla.redhat.com/show_bug.cgi?id=2299712#c10 before uploading a new
submission. I had a feeling I had forgotten to do something, and now I know
what it was.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2299712

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299712%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux