[Bug 2299173] Review Request: rust-virtio-vsock - Virtio vsock device implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2299173



--- Comment #24 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Sandro Bonazzola from comment #18)
> (In reply to Fabio Valentini from comment #14)
> > (In reply to Sandro Bonazzola from comment #8)
> > > Looking at above fedora review you pasted, I'm a bit worried about:
> > > 
> > > Package requires other packages for directories it uses.
> > >      Note: No known owner of /usr/share, /usr/share/cargo/registry,
> > >      /usr/share/cargo, /usr/share/licenses, /usr
> > > 
> > > I'm checking this one, I'll push an update.
> > 
> > This is a false positive from fedora-review. The directories *are* owned.
> > Please don't own them again. 
> 
> I know, it's just the generated rpm is not requiring the packages that on
> those directories.

No, it appears you misunderstood.

The rust-*-devel packages have an automatically added hard "Requires: cargo",
and "cargo" owns "/usr/share/cargo/registry".
The error printed by fedora-review error is just *wrong*.

> > If you think something generated by rust2rpm is wrong, please don't just
> > monkey-patch it, but report a bug against rust2rpm.
> 
> Done: https://pagure.io/fedora-rust/rust2rpm/issue/282
> 
> > Side note:
> > Pasting the fedora-review template isn't really helpful if the items with
> > empty [ ] checkboxes aren't checked manually and filled [x] or [!].
> 
> Yes. @Dorinda can you please complete manual checks in next review round?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2299173

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299173%23c24

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux