https://bugzilla.redhat.com/show_bug.cgi?id=2297646 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #7) > (In reply to Fabio Valentini from comment #4) > > Thank you for the review! > > I've added the second suggestion (only processing .md and .rs files) and > > uploaded new spec and SRPM files at the same URLs. > > > > [fedora-review-service-build] > > I’m on a phone, but the spec-file diff shows that you are running dos2unix > on all files, without filtering on extension, i.e. the first suggestion. > > That should be OK, as there are no binary files in the crate and dos2unix > itself does some kind of heuristic filtering to avoid mangling binary files, > but it’s not what your comment said you intended to do. I’m going to go ahead and approve the package, because it is acceptable as-is, but please double-check this to make sure you’re doing exactly what you wanted to. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2297646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297646%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
