https://bugzilla.redhat.com/show_bug.cgi?id=2294718 --- Comment #12 from Jerry James <loganjerry@xxxxxxxxx> --- This package needs a lot of work. You must be following some very out-of-date packaging advice. Please see https://rpm-packaging-guide.github.io/ for modern instructions. See "Issues" below for specifics. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING-DOCS is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Remove all instances of "Group: Applications/Editors". See the 2nd bullet of https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections. Fedora has not used the Group tag for many years. - Remove "%global debug_package %{nil}". If that causes another problem, we need to solve that problem rather than cover it up. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ - I think the License field may need more license terms. Please run a license checking tool, such as licensecheck or scancode-toolkit. - The autoconf BuildRequires is never used. You would need it to regenerate the configure script from configure.ac, but this spec file does not do that. - The configure script reports that it cannot find an lpr command. Add "BuildRequires: cups-client" to the spec file to fix that. - Change "BuildRequires: fontpackages-devel" to "BuildRequires: fonts-rpm-macros" for future compatibility. - Some of the BuildRequires should use the pkgconfig syntax. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_buildrequires_based_on_pkg_config. I suggest the following BuildRequires transformations: freetype-devel -> pkgconfig(freetype2) libjpeg-devel -> pkgconfig(libjpeg) xorg-x11-proto-devel -> pkgconfig(xproto) libX11-devel -> pkgconfig(x11) - Why is gettext a Requires? Shouldn't it be a BuildRequires instead? - Since yudit-data install icons into /usr/share/icons/hicolor, add "Requires: hicolor-icon-theme" to the "%package yudit-data" section. - The main package creates the directory /usr/share/yudit/config, but none of the 3 packages owns that directory. - I can understand the main package having "Requires: yudit-data", but why does it also have "Requires: yudit-doc"? That seems wrong. A user should be able to forego documentation if the user doesn't want it. - Both yudit-data and yudit-doc have "BuildArch: noarch" in %description. You can see it in the output of "rpm -qip yudit-data-3.1.0-4.fc41.x86_64.rpm" ... which is an x86_64 rpm instead of a noarch rpm precisely because of this. The BuildArch tag has to be in the %package section, not the %description section. - The three packages repeat the same %description. Instead, consider adding this just above %description: %global desc %{expand: Yudit is a Unicode text editor for the X Window ... } Then use that macro in each %description, like this: %description %desc %description data %desc %description doc %desc The data and doc subpackages currently have a final sentence that is lacking in the main package. You can move those sentences to the line after the appropriate %description in each case. - Move %configure from %prep to %build. Some macros expand differently in the two sections. - Can you successfully replace "make" with "%make_build"? If so, do so. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make - In %install, remove "rm -fr $RPM_BUILD_ROOT". See the 3rd bullet of https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections - In %install, replace "make DESTDIR=$RPM_BUILD_ROOT install" with %make_install. You probably don't need the two mkdir commands above it. - Why is yudit.properties installed in both /etc/yudit and /usr/share/yudit/config? - Replace hardcoded pathnames with macros (%{_sysconfdir}, %{_datadir}, etc.): https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation - Remove %defattr from %files. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions - Language files are not handled correctly. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#handling_locale_files - Fonts are not handled correctly. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_avoid_bundling_of_fonts_in_other_packages - The MimeType field in the desktop file needs some work. See https://www.iana.org/assignments/media-types/media-types.xhtml for the official MIME type names. So, for example, there is no "text/english". I have never seen most of those "text/x-*" MIME types. Does anything actually use those, or is this just an attempt to make yudit the default editor for lots of file types? If the latter, this is the wrong way to do it. - Please consider adding an AppData file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - Please consider using %autorelease and %autochangelog. You can preserve upstream's changelog by creating a file named "changelog" when importing the package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs - The build log shows quite a few instances of this warning: warning: ‘operator delete(void*, unsigned long)’ called on pointer returned from a mismatched allocat ion function [-Wmismatched-new-delete] The code should be using "delete []" instead of "delete" in those instances. Please report this to upstream. Using the wrong delete operator is undefined behavior. Bad things might happen! - Please let upstream know that their various COPYING files have a very old address for the FSF. It is out of date by 19 years. They should either give a correct address, or not give a physical address at all. The FSF itself recommends giving a web address instead, as can be seen in their GPL 3.0 text: https://www.gnu.org/licenses/gpl-3.0.html - Nitpick: there are some weird spacing issues in this spec file. Why do some of the BuildRequires have 2 spaces after the colon and some only one, for example? Why is the %description text wrapped at only 48 columns? That is very narrow. Also the %description text has been justified. Don't do that. The description text will be displayed in various GUI tools that will do their own word-wrapping and justification. Finally, fix the changelog entry dated Mon Jul 01 2024 to have a space after the leading '*'. (Also, the word "separate" is misspelled in that entry.) - Another nitpick: in the %description, the software is referred to as "she" and "her". This sounds strange to my native American English ears. I would use the words "it" and "its", respectively. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "FSF Unlimited License [generated file]", "GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)]", "GNU General Public License", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "X11 License [generated file]", "*No copyright* GNU General Public License", "Creative Commons Attribution-ShareAlike 3.0", "GNU Free Documentation License v1.1", "GNU Free Documentation License v1.1 or later", "Unicode strict", "MIT License". 756 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2294718-yudit/licensecheck.txt Some files seem to be covered by licenses other than GPL-2.0-only. The appropriate license names should be added to License. [x]: License file installed when any subpackage combination is installed. However, note that I object to the doc package being required from the main package. If that is changed, the license file will need to be added to the data subpackage as well. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/yudit/config [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/yudit/config, /usr/share/yudit, /usr/share/icons/hicolor/48x48 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. Mostly, except for the missing space after a '*' noted above. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required This should be removed, as noted above. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed This should be removed, as noted above. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: The spec file handles locales properly. This should be fixed, as noted above. [!]: Package consistently uses macros (instead of hard-coded directory names). This should be fixed, as noted above. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Problems noted above. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. This must be fixed, as noted above. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines Exceptions noted above. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files This should be fixed, as noted above. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yudit- data [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. However, an md5sum IS published. Please consider checking it. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. The upstream tarball does contain tests. Can we run them in %check? [!]: Packages should try to preserve timestamps of original installed files. Please add the "-p" flag to invocations of cp and install. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 10885120 bytes in /usr/share See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines This is due to the misplacement of "BuildArch: noarch" noted above. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: yudit-3.1.0-4.fc41.x86_64.rpm yudit-data-3.1.0-4.fc41.x86_64.rpm yudit-doc-3.1.0-4.fc41.x86_64.rpm yudit-3.1.0-4.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxf9d09u5')] checks: 32, packages: 4 yudit-data.x86_64: W: tag-in-description BuildArch: yudit-doc.x86_64: W: tag-in-description BuildArch: yudit-data.x86_64: E: spelling-error ('noarch', '%description -l en_US noarch -> no arch, no-arch, monarch') yudit-doc.x86_64: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code') yudit-doc.x86_64: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') yudit-doc.x86_64: E: spelling-error ('documetation', '%description -l en_US documetation -> documentation, domestication') yudit-doc.x86_64: E: spelling-error ('noarch', '%description -l en_US noarch -> no arch, no-arch, monarch') yudit-data.x86_64: W: no-documentation yudit-data.x86_64: E: no-binary yudit-doc.x86_64: E: no-binary yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/licenses/yudit-doc/COPYING.TXT yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/COPYING.TXT yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/cs/COPYING-DOCS yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/cs/README-DOCS.TXT yudit-doc.x86_64: E: files-duplicated-waste 155931 yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/FAQ.TXT /usr/share/doc/yudit-doc/FAQ.TXT yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-arabic.txt /usr/share/doc/yudit-doc/HOWTO-arabic.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-baybayin.txt /usr/share/doc/yudit-doc/HOWTO-baybayin.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-berber.txt /usr/share/doc/yudit-doc/HOWTO-berber.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-bidi.txt /usr/share/doc/yudit-doc/HOWTO-bidi.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-build.txt /usr/share/doc/yudit-doc/HOWTO-build.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-configure.txt /usr/share/doc/yudit-doc/HOWTO-configure.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-devanagari.txt /usr/share/doc/yudit-doc/HOWTO-devanagari.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-freehand.txt /usr/share/doc/yudit-doc/HOWTO-freehand.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-georgian.txt /usr/share/doc/yudit-doc/HOWTO-georgian.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-greekancient.txt /usr/share/doc/yudit-doc/HOWTO-greekancient.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-japanese.txt /usr/share/doc/yudit-doc/HOWTO-japanese.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-keymap.txt /usr/share/doc/yudit-doc/HOWTO-keymap.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-malayalam.txt /usr/share/doc/yudit-doc/HOWTO-malayalam.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-rovasiras.txt /usr/share/doc/yudit-doc/HOWTO-rovasiras.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-syntax.txt /usr/share/doc/yudit-doc/HOWTO-syntax.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-tamil.txt /usr/share/doc/yudit-doc/HOWTO-tamil.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-tibetan.txt /usr/share/doc/yudit-doc/HOWTO-tibetan.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-vietnamese.txt /usr/share/doc/yudit-doc/HOWTO-vietnamese.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-windows.txt /usr/share/doc/yudit-doc/HOWTO-windows.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/README.TXT /usr/share/doc/yudit-doc/README.TXT yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/COPYING.TXT /usr/share/licenses/yudit-doc/COPYING.TXT yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/am/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/az/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/bg/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/bn/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/fi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ga/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/gu/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/hi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ja/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ko/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/mn/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/mr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/pa/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ta/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ur/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/yi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/zh/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/yudit.mo ========= 4 packages and 0 specfiles checked; 12 errors, 57 warnings, 14 filtered, 12 badness; has taken 0.8 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 yudit.x86_64: W: unused-direct-shlib-dependency /usr/bin/uniprint /lib64/libX11.so.6 yudit-data.x86_64: W: tag-in-description BuildArch: yudit-doc.x86_64: W: tag-in-description BuildArch: yudit-data.x86_64: E: spelling-error ('noarch', '%description -l en_US noarch -> no arch, no-arch, monarch') yudit-doc.x86_64: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code') yudit-doc.x86_64: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') yudit-doc.x86_64: E: spelling-error ('documetation', '%description -l en_US documetation -> documentation, domestication') yudit-doc.x86_64: E: spelling-error ('noarch', '%description -l en_US noarch -> no arch, no-arch, monarch') yudit-data.x86_64: W: no-documentation yudit-data.x86_64: E: no-binary yudit-doc.x86_64: E: no-binary yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/licenses/yudit-doc/COPYING.TXT yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/COPYING.TXT yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/cs/COPYING-DOCS yudit-doc.x86_64: E: incorrect-fsf-address /usr/share/yudit/doc/cs/README-DOCS.TXT yudit-doc.x86_64: E: files-duplicated-waste 155931 yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/FAQ.TXT /usr/share/doc/yudit-doc/FAQ.TXT yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-arabic.txt /usr/share/doc/yudit-doc/HOWTO-arabic.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-baybayin.txt /usr/share/doc/yudit-doc/HOWTO-baybayin.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-berber.txt /usr/share/doc/yudit-doc/HOWTO-berber.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-bidi.txt /usr/share/doc/yudit-doc/HOWTO-bidi.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-build.txt /usr/share/doc/yudit-doc/HOWTO-build.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-configure.txt /usr/share/doc/yudit-doc/HOWTO-configure.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-devanagari.txt /usr/share/doc/yudit-doc/HOWTO-devanagari.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-freehand.txt /usr/share/doc/yudit-doc/HOWTO-freehand.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-georgian.txt /usr/share/doc/yudit-doc/HOWTO-georgian.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-greekancient.txt /usr/share/doc/yudit-doc/HOWTO-greekancient.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-japanese.txt /usr/share/doc/yudit-doc/HOWTO-japanese.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-keymap.txt /usr/share/doc/yudit-doc/HOWTO-keymap.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-malayalam.txt /usr/share/doc/yudit-doc/HOWTO-malayalam.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-rovasiras.txt /usr/share/doc/yudit-doc/HOWTO-rovasiras.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-syntax.txt /usr/share/doc/yudit-doc/HOWTO-syntax.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-tamil.txt /usr/share/doc/yudit-doc/HOWTO-tamil.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-tibetan.txt /usr/share/doc/yudit-doc/HOWTO-tibetan.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-vietnamese.txt /usr/share/doc/yudit-doc/HOWTO-vietnamese.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/HOWTO-windows.txt /usr/share/doc/yudit-doc/HOWTO-windows.txt yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/README.TXT /usr/share/doc/yudit-doc/README.TXT yudit-doc.x86_64: W: files-duplicate /usr/share/yudit/doc/COPYING.TXT /usr/share/licenses/yudit-doc/COPYING.TXT yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/am/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/az/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/bg/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/bn/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/fi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ga/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/gu/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/hi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ja/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ko/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/mn/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/mr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/pa/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ta/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/ur/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/yi/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/zh/LC_MESSAGES/yudit.mo yudit-data.x86_64: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/yudit.mo 3 packages and 0 specfiles checked; 12 errors, 58 warnings, 10 filtered, 12 badness; has taken 0.5 s Requires -------- yudit (rpmlib, GLIBC filtered): config(yudit) gettext libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) yudit-data yudit-doc yudit-data (rpmlib, GLIBC filtered): yudit-doc (rpmlib, GLIBC filtered): Provides -------- yudit: application() application(yudit.desktop) config(yudit) mimehandler(application/x-shellscript) mimehandler(text/english) mimehandler(text/plain) mimehandler(text/x-c) mimehandler(text/x-c++) mimehandler(text/x-c++hdr) mimehandler(text/x-c++src) mimehandler(text/x-chdr) mimehandler(text/x-csrc) mimehandler(text/x-java) mimehandler(text/x-makefile) mimehandler(text/x-moc) mimehandler(text/x-pascal) mimehandler(text/x-tcl) mimehandler(text/x-tex) yudit yudit(x86-64) yudit-data: yudit-data yudit-data(x86-64) yudit-doc: yudit-doc yudit-doc(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2294718 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, Java, Haskell, Ruby, Ocaml, Perl, fonts, SugarActivity, R, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2294718 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294718%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
