[Bug 2279010] Review Request: aws-c-http - C99 implementation of the HTTP/1.1 and HTTP/2 specifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2279010



--- Comment #6 from Dominik Wombacher <dominik@xxxxxxxxxxxx> ---
(In reply to Neal Gompa from comment #5)
> I see one issue in your spec:
> 
> In the libs subpackage, you have:
> 
> > Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> This probably should be on the main subpackage instead to have it require
> the libs subpackage.

Moved it to the main package and dropped it from the libs sub-package.

```
diff --git a/aws-c-http.spec b/aws-c-http.spec
index 5922970..fa16495 100755
--- a/aws-c-http.spec
+++ b/aws-c-http.spec
@@ -19,6 +19,8 @@ BuildRequires:  numactl-devel
 BuildRequires:  aws-c-compression-devel
 BuildRequires:  aws-c-io-devel

+Requires:       %{name}-libs%{?_isa} = %{version}-%{release}
+
 # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
 ExcludeArch:    %{ix86}
 # Dependencies like aws-c-common don't support and build on s390x
@@ -31,7 +33,6 @@ ExcludeArch: s390x

 %package libs
 Summary:        %{summary}
-Requires:       %{name}%{?_isa} = %{version}-%{release}
```

local mockbuild and copr build successful:
https://copr.fedorainfracloud.org/coprs/wombelix/aws-c-libs/build/7776067/

Spec URL:
https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07776067-aws-c-http/aws-c-http.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07776067-aws-c-http/aws-c-http-0.8.2-1.fc41.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279010

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279010%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux