https://bugzilla.redhat.com/show_bug.cgi?id=2278424 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > I have rewrapped %description at 79 characters. See if that looks better to you. Yes, thank you. > > %{?with_doc:-x rtd}%{?with_test:-x testing} Maybe like this: features=( %{?with_test:"testing"} %{?with_doc:"rtd"} ) features=$(IFS=,; echo "${features[*]}") %pyproject_buildrequires ${features:+-x ${features}} It's longer, but I think it's more readable. It also scales to more than two "features". (I know this doesn't matter :)) + package names is OK + builds and installs OK + license is acceptable for Fedora (BSD-3-Clause) + license is specified correctly (with spdx) + builds and installs OK + BR/P/R look correct + %check is present and passes Package is APPROVED. One more suggestion: add '-v' to %pytest so that individual test names are printed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2278424 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202278424%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
