https://bugzilla.redhat.com/show_bug.cgi?id=2249375 --- Comment #6 from Antoine Damhet <antoine.damhet@xxxxxxxxx> --- Hi Ben, I updated the package to take into account the tox/license issues but I don't agree with the `/usr/bin/pass-audit` file. Since it's a plugin of `pass` the user should call the entrypoint via `pass audit <options>` (that will make pass load and call the `/usr/lib/password-store/extensions/audit.bash` file). The man page correctly references the `pass audit <xx>` command as for the completion files the bash completion file is working as expected but looking closer into it I think the zsh completion is broken: It triggers with `pass-audit` and the output looks like: ``` $ pass-audit zsh: _pass_complete_entries_with_subdirs: command not found... -zsh: _pass_complete_entries_with_subdirs: command not found... pass-audit - --help -h -- display help information --name -n -- check only passwords with this filename --quiet -q -- be quiet --verbose -v -- be verbose --version -V -- display version information ``` I'll look into fixing it but I don't know how yet, can we move forward with the package ? If so, should I remove the zsh completion file while it's broken ? Thanks for the review anyway :) Spec URL: https://git.sr.ht/~xdbob/rpm-pass-audit/blob/39162db6f23256e4a0a7ff85aa46379c00a03b4c/pass-audit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/xdbob/pass-audit/fedora-40-x86_64/07765846-pass-audit/pass-audit-1.2-5.fc40.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249375%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
