https://bugzilla.redhat.com/show_bug.cgi?id=2295139 Paul Pfeister <rh-bugzilla@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|fixing review shortly | --- Comment #10 from Paul Pfeister <rh-bugzilla@xxxxxxxxxxxx> --- Whiteboarded as pending a fix, but it actually seems to be correct and ready for review. ----- Review issues: > - If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. Not a C or C++ application so not applicable. > Regarding %check: Upstream only has tests to help with speed testing, and those require connectivity. No tests applicable to building and no tests usable offline. > rustscan.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/rustscan Looking for feedback on this issue and if it's a blocker. > rustscan.x86_64: W: incoherent-version-in-changelog 2.2.3-1 ['2.3.0-1.fc41', '2.3.0-1'] Fixed in linked spec file. ----- Additional note: crates[.]io crate has only recently come back into use. There are issues with that crate, however, so we're still using src for now. This package will most likely switch to crates[.]io in the future once it (and if) it becomes a stable source for the project. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2295139 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295139%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
