https://bugzilla.redhat.com/show_bug.cgi?id=2282430 --- Comment #23 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review! (In reply to Ben Beasley from comment #21) > ===== Issues ===== > > - This is unused (it appears in a dependency list in the Makefile, but isn’t > *actually* used), and should therefore be removed: > > BuildRequires: python3dist(pytest-xdist) Right. It's not used because I failed to setup running tests in parallel. I could have simply used `make test-parallel`. That make target uses `-n auto --dist loadgroup`, which are provided by `pytest-xdist`. I prefer running `pytest` directly, so I'll add those flags upon import. > ===== Notes ===== > > - I wonder if the ftpbench script, > https://github.com/giampaolo/pyftpdlib/blob/master/scripts/ftpbench, is > worth > packaging system-wide like this or not. On one hand, it’s just a > benchmarking > script, and it doesn’t even use pyftpdlib. On the other hand, it does seem > to > be a generally useful FTP benchmarking script, as evidenced by its re-use > in > https://github.com/aio-libs/aioftp/blob/master/ftpbench.py. The only other > contender for the name is https://github.com/selectel/ftpbench, which looks > pretty obscure. > > I’m inclined to say that packaging it is fine, and there is probably no one > right answer. Good catch. I'll leave it in there for now. Should it cause any conflicts, I'm aware and can adjust to solve any potential issues. > - I would have added a spec-file comment explaining how the downstream > keycert.pem file was generated, but this isn’t mandatory. That sounds like a good idea and I should have done that right from the start. Now I will need to scratch my head hard and dig around my browser's history to figure out what the issue was exactly and what guide / hint I followed to solve it. I'll try... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2282430 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282430%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
