https://bugzilla.redhat.com/show_bug.cgi?id=2282430 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #21 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This looks pretty good now! There is an unused BuildRequires that it would be nice to drop, but the package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - This is unused (it appears in a dependency list in the Makefile, but isn’t *actually* used), and should therefore be removed: BuildRequires: python3dist(pytest-xdist) ===== Notes ===== - I wonder if the ftpbench script, https://github.com/giampaolo/pyftpdlib/blob/master/scripts/ftpbench, is worth packaging system-wide like this or not. On one hand, it’s just a benchmarking script, and it doesn’t even use pyftpdlib. On the other hand, it does seem to be a generally useful FTP benchmarking script, as evidenced by its re-use in https://github.com/aio-libs/aioftp/blob/master/ftpbench.py. The only other contender for the name is https://github.com/selectel/ftpbench, which looks pretty obscure. I’m inclined to say that packaging it is fine, and there is probably no one right answer. - I would have added a spec-file comment explaining how the downstream keycert.pem file was generated, but this isn’t mandatory. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 41 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2282430-python-pyftpdlib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. $ rpm -qL -p results/python3-pyftpdlib-1.5.10-2.fc41.noarch.rpm /usr/lib/python3.13/site-packages/pyftpdlib-1.5.10.dist-info/LICENSE [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 48777 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pyftpdlib , python3-pyftpdlib+ssl [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=120739187 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Differences are solely due to expansion of rpmautospec macros. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). All messages are spurious, either spelling errors that are not real errors, or due to rpmlint not understanding the forge macros. Rpmlint ------- Checking: python3-pyftpdlib-1.5.10-2.fc41.noarch.rpm python3-pyftpdlib+ssl-1.5.10-2.fc41.noarch.rpm python-pyftpdlib-1.5.10-2.fc41.src.rpm ============================================================================================ rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprdk3bq_s')] checks: 32, packages: 3 python-pyftpdlib.src: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python-pyftpdlib.src: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python-pyftpdlib.src: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python-pyftpdlib.src: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python-pyftpdlib.src: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python-pyftpdlib.src: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python3-pyftpdlib+ssl.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-pyftpdlib+ssl.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-pyftpdlib.noarch: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python3-pyftpdlib.noarch: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python3-pyftpdlib.noarch: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python3-pyftpdlib.noarch: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python3-pyftpdlib.noarch: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python3-pyftpdlib.noarch: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python-pyftpdlib.spec: W: patch-not-applied Patch0: unbundle_asyncore_and_asynchat.patch python3-pyftpdlib+ssl.noarch: W: no-documentation ===================================================== 3 packages and 0 specfiles checked; 14 errors, 2 warnings, 31 filtered, 14 badness; has taken 1.0 s ====================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-pyftpdlib+ssl.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-pyftpdlib+ssl.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-pyftpdlib.noarch: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python3-pyftpdlib.noarch: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python3-pyftpdlib.noarch: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python3-pyftpdlib.noarch: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python3-pyftpdlib.noarch: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python3-pyftpdlib.noarch: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python3-pyftpdlib+ssl.noarch: W: no-documentation 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 24 filtered, 8 badness; has taken 0.3 s Source checksums ---------------- https://github.com/giampaolo/pyftpdlib/archive/release-1.5.10/pyftpdlib-release-1.5.10.tar.gz : CHECKSUM(SHA256) this package : 993a48b652c0a2ab9af898fd3acbe422e8558ba91d1451eec20db2584a0178de CHECKSUM(SHA256) upstream package : 993a48b652c0a2ab9af898fd3acbe422e8558ba91d1451eec20db2584a0178de Requires -------- python3-pyftpdlib (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.13dist(pyasynchat) python3.13dist(pyasyncore) python3-pyftpdlib+ssl (rpmlib, GLIBC filtered): python(abi) python3-pyftpdlib python3.13dist(pyopenssl) Provides -------- python3-pyftpdlib: ftpbench python-pyftpdlib python3-pyftpdlib python3.13-pyftpdlib python3.13dist(pyftpdlib) python3dist(pyftpdlib) python3-pyftpdlib+ssl: python-pyftpdlib+ssl python3-pyftpdlib+ssl python3.13-pyftpdlib+ssl python3.13dist(pyftpdlib[ssl]) python3dist(pyftpdlib[ssl]) Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2282430-python-pyftpdlib/srpm/python-pyftpdlib.spec 2024-07-18 14:15:50.106484389 -0400 +++ /home/ben/fedora/review/2282430-python-pyftpdlib/srpm-unpacked/python-pyftpdlib.spec 2024-07-02 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pypi_name pyftpdlib @@ -124,3 +134,12 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jul 03 2024 Sandro <devel@xxxxxxxxxxxxx> - 1.5.10-2 +- Package ssl extra + +* Wed Jul 03 2024 Sandro <devel@xxxxxxxxxxxxx> - 1.5.10-1 +- Update to 1.5.10 + +* Wed May 22 2024 Sandro <devel@xxxxxxxxxxxxx> - 1.5.9-1 +- Initial package +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2282430 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Haskell, Java, R, Perl, SugarActivity, fonts, C/C++, Ocaml, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2282430 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282430%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
