https://bugzilla.redhat.com/show_bug.cgi?id=2297994 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Considering # Generated by rust2rpm 26 #---- cross_validate_constants_with_c stdout ---- #Constant value mismatch for PANEL_MINOR_VERSION #Rust: "3" #C: "6" #Constant value mismatch for PANEL_VERSION_S #Rust: "1.3.0" #C: "1.6.0" #thread 'cross_validate_constants_with_c' panicked at tests/abi.rs:112:13: #FAILED: 11 passed; 2 failed I think that skipping all of the tests is not the right way to handle this. It seems like these constants (PANEL_MAJOR_VERSION, PANEL_MINOR_VERSION, PANEL_MICRO_VERSION, and PANEL_VERSION_S, https://gitlab.gnome.org/World/Rust/libpanel-rs/-/blob/main/sys/src/lib.rs?ref_type=heads#L42) are designed to expose the version of the C libpanel library. On the other hand, they are also part of a file that is generated from GIR, so maybe it doesn’t make sense to patch these (because they correctly reflect that the Rust bindings were generated against an older libpanel version). If we decide it’s OK for these constants to disagree with the packaged libpanel version, then it would at least be better to skip *only* the tests that fail because of the mismatch, similar to https://bugzilla.redhat.com/show_bug.cgi?id=2292542#c9. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2297994 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297994%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
