https://bugzilla.redhat.com/show_bug.cgi?id=2295191 --- Comment #5 from Jens Petersen <petersen@xxxxxxxxxx> --- Thanks for looking, Zbigniew (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > > %bcond_with tests > > I don't think we should use the old form, but that's something to fix in > cabal-rpm. > Doesn't make sense to change this manually here. Good point, I will change that in the next cabal-rpm release (after 2.2.1). > > > %changelog > > Can we please use %autorelease+%autochangelog for new packages? Sure thing - I sometimes find rpmautospec awkward during the review phase, but I can do that now. I have been converting most Haskell packages to autospec. > Anyway, the package looks good. I asked in the fedora-devel thread about > renaming the tool though. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295191 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295191%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
