[Bug 2279777] Review Request: fastapi-cli - Run and manage FastAPI apps from the command line with FastAPI CLI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2279777



--- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Jonathan Steffan from comment #5)
> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fastapi-
>      cli-slim , fastapi-cli-slim+standard
> 
> This seems fine as is since the main package is a meta package. However, I
> wanted to point out the missing %{?_isa}.
> 
> 
> Requires: %{name}%{?_isa} = %{version}-%{release}

Such dependencies should definitely be arch-specific whenever possible, but
that’s only when an arched (sub)package is depending on another arched
(sub)package. In this case, the package is noarch, so we can’t use %{_isa}. It
would expand to the architecture of the builder (which is arbitrary for a
noarch package) and result in a broken dependency.

$ rpm -q --provides -p
results_fastapi-cli/0.0.3/1.fc41/fastapi-cli-slim-0.0.3-1.fc41.noarch.rpm 
fastapi-cli-slim = 0.0.3-1.fc41
python-fastapi-cli-slim = 0.0.3-1.fc41
python3-fastapi-cli-slim = 0.0.3-1.fc41
python3.12-fastapi-cli-slim = 0.0.3-1.fc41
python3.12dist(fastapi-cli-slim) = 0.0.3
python3dist(fastapi-cli-slim) = 0.0.3


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279777

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279777%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux