https://bugzilla.redhat.com/show_bug.cgi?id=2296300 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Felix Schwarz from comment #4) > Everything looks fine to me. > > Two thoughts related to the cli package (which is disabled for now): > - /usr/bin/dav seems to be a pretty generic name to me I agree. On the other hand, it’s the name that users and scripts that depend on the CLI will expect, and the only other project I could find in a quick search that seems to have a claim on the name is https://github.com/atsb/dav-text – and it seems to be relatively inactive. So I think the generic name could be OK for Fedora, but at the same time, it would be nice if it were more unique, so I filed https://github.com/skshetry/webdav4/issues/179 upstream. > - Assuming we provide the cli at some point. Is python3-webdav4 still the > right package name? Yes, since both are built from the same source they should be a single source package, and then per https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming it’s just a judgement call as to whether it “primarily” provides an application (in which case webdav4 would be the right name) or a library (in which case python-webdav4 would be the right name). I think the application and library are perhaps nearly equal here, but for now we are packaging this to get the library, and renaming once the CLI was available would only make sense if the CLI application were *much* more important, and the library mostly just existed to support the application. Now, if you are asking about whether the CLI should be shipped in a separate binary package? I’m inclined to say no since packages that ship a command-line tool as part of a python3-whatever library package like this are extremely common in Fedora. It can make sense to ship a CLI separately if there are a lot of support files for it that we can avoid installing when only the library dependency is needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2296300 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296300%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
