https://bugzilla.redhat.com/show_bug.cgi?id=2268499 --- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the update! Looks pretty good already. 1. Issue with the License tag - it's not valid, and incomplete. - The license identifier is not GPLv3, but either GPL-3.0-or-later or GPL-3.0-only. It's not clear to me which one is correct. The license is not specified in Cargo.toml (which is also why it's missing from the summary printed during the build. Upstream might want to set the crate license in Cargo.toml metadata. Please also clarify whether the license is GPL-3.0-or-later or GPL-3.0-only, this is not clear from the license text and README. - The license tag doesn't apply the "no effective license" rule. It should look like this (assuming GPL-3.0-only): License: GPL-3.0-only AND CC-BY-4.0 AND Apache-2.0 AND BSD-3-Clause AND MIT AND MPL-2.0 AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR ISC OR MIT) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) 2. Some rpmlint messages that are indeed not wrong: gotify-desktop.src: E: summary-too-long Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.x86_64: E: summary-too-long Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.src: W: summary-ended-with-dot Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.x86_64: W: summary-ended-with-dot Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.x86_64: E: script-without-shebang /usr/share/icons/hicolor/scalable/apps/gotify-logo-small.svg gotify-desktop.x86_64: W: no-manual-page-for-binary gotify-desktop gotify-desktop.spec:39: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 39) gotify-desktop.src: E: description-line-too-long Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.x86_64: E: description-line-too-long Small Gotify daemon to receive messages and forward them as desktop notifications. gotify-desktop.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/gotify-desktop SSL_CTX_set_cipher_list TODO items: - trim summary and remove trailing dot / full stop - line-wrap description at 72 characters. - replace TAB character with spaces. (seems to be on the line where Source1 is defined) - install icon with mode 644 instead of mode 755, it's not an executable file The "crypto-policy-non-compliance-openssl" is a false positive, it is shared by all Rust applications that use the OpenSSL crate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2268499 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268499%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
