https://bugzilla.redhat.com/show_bug.cgi?id=2291288 --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to U2FsdGVkX1 from comment #6) > I'm very sorry. I just saw your comment now. > It seems there is a new Review Request. If possible, I can help you review > the new version. No worries. The review got done, so I'm happy. > I have fixed all the issues except the license (the upstream version already > provides a license file, unfortunately it is still an alpha version) > Thank you very much for your review. This is much better. I still have a few questions, though. - The spec file still contains "BuildRequires: coq". What is that for? I don't see any mention of coq in the upstream tarball. - I don't know why my earlier review didn't turn this up, but upstream requires the "bytes" library, which doesn't work with OCaml 5.x. Remove the mention of "bytes" in src/dune. - The %description text was wrapped rather weirdly. May I suggest the following? And it is only a suggestion; you don't have to do this. %description Omd is an OCaml library designed to parse, manipulate, and print Markdown into different formats. In addition to the library, a command-line tool omd is included to easily convert markdown into HTML. - I would still like to suggest using help2man to generate a man page for the binary. This is again just a suggestion, not required. To do so, add "BuildRequires: help2man", then add this to %install: mkdir -p %{buildroot}%{_mandir}/man1 help2man -N --version-string=%{version} -o %{buildroot}%{_mandir}/man1/omd.1 \ -n 'Convert markdown to HTML' %{buildroot}%{_bindir}/omd Finally, add this to %files: %{_mandir}/man1/omd.1* -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2291288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291288%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
