https://bugzilla.redhat.com/show_bug.cgi?id=2283685 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some comments: 1. Rather than needing to make manual adjustments after dropping the binary, I would recommend to patch in "package.autobins = false". 2. If you're removing functionality for "cli" and "display", don't keep empty dummy features for them. Just remove them entirely. 3. The test suite fails to compile on non-x86 architectures, but the crate itself does (though looks like with most functionality disabled): https://koji.fedoraproject.org/koji/taskinfo?taskID=120239066 You will either need to use the `package.supported-arches = ["x86_64", "i686"]` setting in rust2rpm.toml or wrap the %cargo_test macro like this: ``` %ifarch x86_64 %{ix86} %cargo_test %endif ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283685 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283685%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
