https://bugzilla.redhat.com/show_bug.cgi?id=2296293 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@xxxxxxxxx Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx --- Comment #3 from Cristian Le <fedora@xxxxxxxxx> --- I can take the review, but I can't sponsor, and that may take some time. Maybe your sponsor would (also) do the review. Quick notes: - Can you add a comment in the format that you see in the template https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review That will make fedora-review create a copr build and do some automated tests - Can you post the rust2rpm.toml that you've used if any - The license seems inconsistent with the note on the readme file [1] (GPL-3.0-only vs GPL-3.0-or-later). Could you make an issue/PR to upstream to update the metadata in Cargo.toml - I am not familiar with `CodeDependencies.iss` [2], but it seems that it is copied from another project [3]. At the very least this would require merging the license, but I would need to check CPOL if it's allowed. I am not sure if there is other procedures to be had with this like marking it as `bundled`, will put this up for further review - I believe the spec file in that format would not build. Can you work on it in a copr repo, either by uploading the srpm manually, or you can copy a workflow I have in a repo [4] (feel free to contact me on matrix/github if you want tips on how to set it up) [1]: https://github.com/russellbanks/Komac/blob/v2.3.0/README.md#license [2]: https://github.com/russellbanks/Komac/blob/v2.3.0/assets/CodeDependencies.iss [3]: https://github.com/DomGries/InnoDependencyInstaller [4]: https://github.com/LecrisUT/tonic-rpmspec/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2296293 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296293%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
