https://bugzilla.redhat.com/show_bug.cgi?id=2291288 --- Comment #6 from U2FsdGVkX1@xxxxxxxxx --- (In reply to Jerry James from comment #4) > I will take this review. If you are willing to do a review on exchange, > could you review bug 2294765 for me? I'm very sorry. I just saw your comment now. It seems there is a new Review Request. If possible, I can help you review the new version. (In reply to Jerry James from comment #5) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - There seem to be unnecessary BuildRequires. In fact, the only > BuildRequires > that appear to be needed are ocaml (>= 4.04, not >= 4.08.1 as in the spec > file) and ocaml-dune. > > - The OCaml stack is no longer built for 32-bit x86. All current OCaml spec > files contain these lines: > > # OCaml packages not built on i686 since OCaml 5 / Fedora 39. > ExcludeArch: %{ix86} > > Please add them to this spec file as well. > > - Please ask upstream to include the license file in future tarballs. > > - Please capitalize the first letter of the summary; see the > summary-not-capitalized rpmlint warning below. > > - Please wrap the text in %description at about 72 characters. See the > description-line-too-long rpmlint warning below. > > - Please consider using help2man to generate a man page for the omd binary. > > ===== MUST items ===== > > C/C++: > [x]: Package does not contain kernel modules. > [x]: Package does not contain any libtool archives (.la) > [x]: Package contains no static executables. > [x]: Rpath absent or only used for internal libs. > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "*No copyright* ISC License [generated > file]", "GNU Lesser General Public License", "ISC License". 235 files > have unknown license. Detailed output of licensecheck in > /home/jamesjer/2291288-ocaml-omd/licensecheck.txt > [x]: License file installed when any subpackage combination is installed. > [x]: %build honors applicable compiler flags or justifies otherwise. > [x]: Package contains no bundled libraries without FPC exception. > [x]: Changelog in prescribed format. > [x]: Sources contain only permissible code or content. > [-]: Package contains desktop file if it is a GUI application. > [x]: Development files must be in a -devel package > [x]: Package uses nothing in %doc for runtime. > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [x]: Package is named according to the Package Naming Guidelines. > [x]: Package does not generate any conflict. > [x]: Package obeys FHS, except libexecdir and /usr/target. > [-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [x]: Requires correct, justified where necessary. > [x]: Spec file is legible and written in American English. > [-]: Package contains systemd file(s) if in need. > [x]: Useful -debuginfo package or justification otherwise. > [x]: Package is not known to require an ExcludeArch tag. > [x]: Package complies to the Packaging Guidelines > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: The License field must be a valid SPDX expression. > [x]: Package requires other packages for directories it uses. > [x]: Package must own all directories that it creates. > [x]: Package does not own files or directories owned by other packages. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package must not depend on deprecated() packages. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 7307 bytes in 2 files. > [x]: Packages must not store files under /srv, /opt or /usr/local > > Ocaml: > [x]: This should never happen > > ===== SHOULD items ===== > > Generic: > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [x]: Package functions as described. > [x]: Latest version is packaged. > [x]: Package does not include license text files separate from upstream. > [-]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. > [x]: Package should compile and build into binary rpms on all supported > architectures. > [x]: %check is present and all tests pass. > [x]: Packages should try to preserve timestamps of original installed > files. > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Fully versioned dependency in subpackages if applicable. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. > > ===== EXTRA items ===== > > Generic: > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) > [x]: Rpmlint is run on debuginfo package(s). > Note: No rpmlint messages. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > > > Rpmlint > ------- > Checking: ocaml-omd-1.3.2-1.fc41.x86_64.rpm > ocaml-omd-devel-1.3.2-1.fc41.x86_64.rpm > ocaml-omd-debuginfo-1.3.2-1.fc41.x86_64.rpm > ocaml-omd-debugsource-1.3.2-1.fc41.x86_64.rpm > ocaml-omd-1.3.2-1.fc41.src.rpm > ================================================ rpmlint session starts > ================================================ > rpmlint: 2.5.0 > configuration: > /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > rpmlintrc: [PosixPath('/tmp/tmpge_j0jvs')] > checks: 32, packages: 5 > > ocaml-omd.src: W: summary-not-capitalized extensible Markdown library and > tool in "pure OCaml" > ocaml-omd.x86_64: W: summary-not-capitalized extensible Markdown library and > tool in "pure OCaml" > ocaml-omd-devel.x86_64: E: static-library-without-debuginfo > /usr/lib64/ocaml/omd/omd.a > ocaml-omd.x86_64: W: no-manual-page-for-binary omd > ocaml-omd-devel.x86_64: W: no-documentation > ocaml-omd.src: E: description-line-too-long Omd is an OCaml library designed > to parse, manipulate, and print Markdown into different formats. In addition > to the library, a command-line tool omd is included to easily convert > markdown into HTML. > ocaml-omd.x86_64: E: description-line-too-long Omd is an OCaml library > designed to parse, manipulate, and print Markdown into different formats. In > addition to the library, a command-line tool omd is included to easily > convert markdown into HTML. > ========== 5 packages and 0 specfiles checked; 3 errors, 4 warnings, 26 > filtered, 3 badness; has taken 0.7 s =========== > > > > > Rpmlint (debuginfo) > ------------------- > Checking: ocaml-omd-debuginfo-1.3.2-1.fc41.x86_64.rpm > ================================================ rpmlint session starts > ================================================ > rpmlint: 2.5.0 > configuration: > /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > rpmlintrc: [PosixPath('/tmp/tmpnf_owaeo')] > checks: 32, packages: 1 > > ========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 > filtered, 0 badness; has taken 0.2 s =========== > > > > > > Rpmlint (installed packages) > ---------------------------- > ============================ rpmlint session starts > ============================ > rpmlint: 2.5.0 > configuration: > /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora-legacy-licenses.toml > /etc/xdg/rpmlint/fedora-spdx-licenses.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > checks: 32, packages: 4 > > ocaml-omd.x86_64: W: summary-not-capitalized extensible Markdown library and > tool in "pure OCaml" > ocaml-omd-devel.x86_64: E: static-library-without-debuginfo > /usr/lib64/ocaml/omd/omd.a > ocaml-omd.x86_64: W: no-manual-page-for-binary omd > ocaml-omd-devel.x86_64: W: no-documentation > ocaml-omd.x86_64: E: description-line-too-long Omd is an OCaml library > designed to parse, manipulate, and print Markdown into different formats. In > addition to the library, a command-line tool omd is included to easily > convert markdown into HTML. > 4 packages and 0 specfiles checked; 2 errors, 3 warnings, 24 filtered, 2 > badness; has taken 0.7 s > > > > Source checksums > ---------------- > https://github.com/ocaml/omd/archive/1.3.2/omd-1.3.2.tar.gz : > CHECKSUM(SHA256) this package : > 42c8c0ce1676eb3c1cfa67548823334cf51114519078d249882eacdfc214d932 > CHECKSUM(SHA256) upstream package : > 42c8c0ce1676eb3c1cfa67548823334cf51114519078d249882eacdfc214d932 > > > Requires > -------- > ocaml-omd (rpmlib, GLIBC filtered): > libc.so.6()(64bit) > libm.so.6()(64bit) > ocaml(CamlinternalFormatBasics) > ocaml(CamlinternalOO) > ocaml(Omd_backend) > ocaml(Omd_lexer) > ocaml(Omd_parser) > ocaml(Omd_representation) > ocaml(Omd_utils) > ocaml(Stdlib) > ocaml(Stdlib__Bigarray) > ocaml(Stdlib__Buffer) > ocaml(Stdlib__Bytes) > ocaml(Stdlib__Complex) > ocaml(Stdlib__Either) > ocaml(Stdlib__Int32) > ocaml(Stdlib__List) > ocaml(Stdlib__Map) > ocaml(Stdlib__Obj) > ocaml(Stdlib__Printexc) > ocaml(Stdlib__Printf) > ocaml(Stdlib__Seq) > ocaml(Stdlib__Set) > ocaml(Stdlib__String) > ocaml(Stdlib__StringLabels) > ocaml(Stdlib__Sys) > ocaml(Stdlib__Uchar) > rtld(GNU_HASH) > > ocaml-omd-devel (rpmlib, GLIBC filtered): > ocaml(CamlinternalFormatBasics) > ocaml(CamlinternalOO) > ocaml(Omd_backend) > ocaml(Omd_lexer) > ocaml(Omd_parser) > ocaml(Omd_representation) > ocaml(Omd_utils) > ocaml(Stdlib) > ocaml(Stdlib__Bigarray) > ocaml(Stdlib__Buffer) > ocaml(Stdlib__Bytes) > ocaml(Stdlib__Complex) > ocaml(Stdlib__Either) > ocaml(Stdlib__Int32) > ocaml(Stdlib__List) > ocaml(Stdlib__Map) > ocaml(Stdlib__Obj) > ocaml(Stdlib__Printexc) > ocaml(Stdlib__Printf) > ocaml(Stdlib__Seq) > ocaml(Stdlib__Set) > ocaml(Stdlib__String) > ocaml(Stdlib__StringLabels) > ocaml(Stdlib__Sys) > ocaml(Stdlib__Uchar) > ocaml-omd(x86-64) > ocamlx(CamlinternalFormat) > ocamlx(CamlinternalOO) > ocamlx(Omd_backend) > ocamlx(Omd_lexer) > ocamlx(Omd_parser) > ocamlx(Omd_representation) > ocamlx(Omd_utils) > ocamlx(Stdlib) > ocamlx(Stdlib__Array) > ocamlx(Stdlib__Buffer) > ocamlx(Stdlib__Bytes) > ocamlx(Stdlib__List) > ocamlx(Stdlib__Map) > ocamlx(Stdlib__Printexc) > ocamlx(Stdlib__Printf) > ocamlx(Stdlib__Set) > ocamlx(Stdlib__String) > ocamlx(Stdlib__StringLabels) > ocamlx(Stdlib__Sys) > > ocaml-omd-debuginfo (rpmlib, GLIBC filtered): > > ocaml-omd-debugsource (rpmlib, GLIBC filtered): > > > > Provides > -------- > ocaml-omd: > ocaml(Html_characters) > ocaml(Omd) > ocaml(Omd_backend) > ocaml(Omd_html) > ocaml(Omd_lexer) > ocaml(Omd_lexer_fs) > ocaml(Omd_parser) > ocaml(Omd_representation) > ocaml(Omd_utils) > ocaml(Omd_xtxt) > ocaml-omd > ocaml-omd(x86-64) > > ocaml-omd-devel: > ocaml(Html_characters) > ocaml(Omd) > ocaml(Omd_backend) > ocaml(Omd_html) > ocaml(Omd_lexer) > ocaml(Omd_lexer_fs) > ocaml(Omd_parser) > ocaml(Omd_representation) > ocaml(Omd_utils) > ocaml(Omd_xtxt) > ocaml-omd-devel > ocaml-omd-devel(x86-64) > ocamlx(Html_characters) > ocamlx(Omd) > ocamlx(Omd_backend) > ocamlx(Omd_html) > ocamlx(Omd_lexer) > ocamlx(Omd_lexer_fs) > ocamlx(Omd_parser) > ocamlx(Omd_representation) > ocamlx(Omd_utils) > ocamlx(Omd_xtxt) > > ocaml-omd-debuginfo: > debuginfo(build-id) > ocaml-omd-debuginfo > ocaml-omd-debuginfo(x86-64) > > ocaml-omd-debugsource: > ocaml-omd-debugsource > ocaml-omd-debugsource(x86-64) > > > > Diff spec file in url and in SRPM > --------------------------------- > --- /home/jamesjer/2291288-ocaml-omd/srpm/ocaml-omd.spec 2024-06-28 > 21:12:29.932394120 -0600 > +++ /home/jamesjer/2291288-ocaml-omd/srpm-unpacked/ocaml-omd.spec 2024-04-24 > 18:00:00.000000000 -0600 > @@ -1,2 +1,12 @@ > +## START: Set by rpmautospec > +## (rpmautospec version 0.6.3) > +## RPMAUTOSPEC: autorelease, autochangelog > +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: > + release_number = 1; > + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); > + print(release_number + base_release_number - 1); > +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} > +## END: Set by rpmautospec > + > Name: ocaml-omd > Version: 1.3.2 > @@ -47,3 +57,6 @@ > > %changelog > -%autochangelog > +## START: Generated by rpmautospec > +* Thu Apr 25 2024 U2FsdGVkX1 <U2FsdGVkX1@xxxxxxxxx> - 1.3.2-1 > +- first commit > +## END: Generated by rpmautospec > > > Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 > Command line :/usr/bin/fedora-review -b 2291288 -m fedora-rawhide-x86_64 > Buildroot used: fedora-rawhide-x86_64 > Active plugins: Ocaml, C/C++, Shell-api, Generic > Disabled plugins: Ruby, PHP, R, Java, fonts, SugarActivity, Python, Haskell, > Perl > Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH I have fixed all the issues except the license (the upstream version already provides a license file, unfortunately it is still an alpha version) Thank you very much for your review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2291288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291288%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
