Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: cronie https://bugzilla.redhat.com/show_bug.cgi?id=428007 mmaslano@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(mmaslano@xxxxxxxxx| |m) | ------- Additional Comments From mmaslano@xxxxxxxxxx 2008-01-25 10:17 EST ------- > - Add the epoch to "Obsoletes: vixie-cron <= 4.3" otherwise upgrading won't > work (a missing epoch has the same effect as a zero epoch) It's ok (comment #27) > Unnecessary build requirement on automake (you don't use it in the spec file, > if the Makefiles try to rebuild themselves, there's something wrong) Removed. > - %preun mustn't fail, add ' || :' to the chkconfig command as well (it's > always the last command that defines the exit code of a %pre/%post/un > scriptlet). Alternatively, just append "exit 0" to all the scriptlets. > See the Fedora Wiki for details ("Syntax" section): > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Added || : > - You unconditionally remove $RPM_BUILD_ROOT%{_sysconfdir}/pam.d/crond.pam in > the %install section (the %if conditional is commented out). You probably > should remove the comments so that the file only gets removed if %{with_pam} The autotools can install crond in the correct place. If someone change it in spec without pam, then the installed file will be removed. I renamed false cron.pam on crond. > Have you checked whether you can leave out the individual %attr flags in the > %files section, i.e. if "make install" installs the files with the proper > %permissions? I removed as many permissions as I dare. I uploaded correct spec file and I'd also built the package in mock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review