https://bugzilla.redhat.com/show_bug.cgi?id=2294727 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | --- Comment #3 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > Looks OK to me. Just please clarify some things: > > - The subpackage for the "mtls" and "x509-parser" features are missing from > the package. > Are these optional features with additional dependencies that you don't > want to package / don't need? Yes. mtls depends on x509-parser, and it isn't available in Fedora. The dependencies that I need are like this (from the top to the bottom): https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5284530ae8c180153d/aw-server/Cargo.toml#L17 https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5284530ae8c180153d/aw-server/Cargo.toml#L18 https://github.com/lawliet89/rocket_cors/blob/master/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L28 so nothing such fancy as mtls is needed. > - Looks like some doctests can only be run inside the upstream git > repository. The doctests you are skipping result in 0 (zero) doctests > remaining that are compiled or run. In this case, it would be much, much > easier to use `%cargo_test -- --lib` instead of manually listing all source > files. Done. I just wasn't aware of that. Thanks for the tip. The spec file is updated in the first post, so rebuilding. [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2294727 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294727%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
