Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: cronie https://bugzilla.redhat.com/show_bug.cgi?id=428007 nphilipp@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(mmaslano@xxxxxxxxx | |m) ------- Additional Comments From nphilipp@xxxxxxxxxx 2008-01-25 09:35 EST ------- CHECK: - Add the epoch to "Obsoletes: vixie-cron <= 4.3" otherwise upgrading won't work (a missing epoch has the same effect as a zero epoch) - Unnecessary build requirement on automake (you don't use it in the spec file, if the Makefiles try to rebuild themselves, there's something wrong) - %preun mustn't fail, add ' || :' to the chkconfig command as well (it's always the last command that defines the exit code of a %pre/%post/un scriptlet). Alternatively, just append "exit 0" to all the scriptlets. See the Fedora Wiki for details ("Syntax" section): http://fedoraproject.org/wiki/Packaging/ScriptletSnippets (I've mentioned the issues above in comment #13 already) - You unconditionally remove $RPM_BUILD_ROOT%{_sysconfdir}/pam.d/crond.pam in the %install section (the %if conditional is commented out). You probably should remove the comments so that the file only gets removed if %{with_pam} isn't defined, and change the command to: rm -f $RPM_BUILD_ROOT%{_sysconfdir}/pam.d/crond I.e. the file name is "crond", not "crond.pam" and recursive removal isn't needed as it's not a directory. GOOD: - Summary and description fixed - URL fixed (will this be the final location?) - Obsolete %triggerpostun removed - Unnecessary use of $RPM_OPT_FLAGS removed - Files aren't moved out of the source/build directory Have you checked whether you can leave out the individual %attr flags in the %files section, i.e. if "make install" installs the files with the proper %permissions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review