[Bug 2293784] Review Request: rust-cargo_toml - Cargo.toml struct definitions for parsing with Serde

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2293784



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

https://release-monitoring.org/project/373300/

(In reply to Fabio Valentini from comment #2)
> Side note: Any projects that use this crate might want to switch to the
> official cargo-util-schemas crate. The de/serialization schemas that are
> used internally by cargo have been split off into a separate project and
> published as a separate crate *exactly* for use cases where other projects
> want to parse Cargo.toml files the same way that cargo does it. see also:
> https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#internal-4

Thanks for pointing this out. I found that porting was quite practical but
slightly less self-contained than I was hoping for, so rather than opening a PR
I just filed a detailed suggestion upstream:
https://github.com/o2sh/onefetch/issues/1361


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2293784

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293784%23c3

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux