https://bugzilla.redhat.com/show_bug.cgi?id=2292943 --- Comment #6 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Tom Hughes from comment #4) > Thanks for the review. > > I'll update the version but I'm not clear why you think adding %dir would be > helpful? The directory is already added along with the files it contained > and the only thing %dir does it to make rpm package the directory without > any files it contains meaning they would then have to be listed separately, > or is that what you're suggesting? the fedora-review output had some (maybe spurious) warnings about dir ownership. i have used the %dir squash these warnings in my own spec files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292943 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292943%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue