Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emacs-lua - Lua major mode for GNU Emacs and XEmacs https://bugzilla.redhat.com/show_bug.cgi?id=429323 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-24 19:32 EST ------- I grabbed the src.rpm from koji. It does build OK; rpmlint says: emacs-lua.noarch: W: no-documentation emacs-lua-el.noarch: W: no-documentation xemacs-lua.noarch: W: no-documentation xemacs-lua-el.noarch: W: no-documentation which are OK; there's just a single .el file in this package which gets byte-compiled. Actually this package is pretty much trivial. One thing you might want to do is use "cp -p" in %build to preserve the timestamps on the el file. It looks like the *emacs-lua-el packages do not require the *emacs-lua packages. This is a blocker. * source files match upstream: 93df13a1916c0cade5b76721f26ffdd20fd248f37706ac1effbbdc80e04342fc lua-mode-20071122.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summaries are OK. * descriptions are OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint has acceptable complaints. X final provides and requires: emacs-lua-20071122-3.fc9.noarch.rpm emacs-lua = 20071122-3.fc9 = emacs(bin) >= emacs_version emacs-lua-el-20071122-3.fc9.noarch.rpm emacs-lua-el = 20071122-3.fc9 = X (should require emacs-lua) xemacs-lua-20071122-3.fc9.noarch.rpm xemacs-lua = 20071122-3.fc9 = xemacs >= 21.5.28 xemacs-lua-el-20071122-3.fc9.noarch.rpm xemacs-lua-el = 20071122-3.fc9 = X (should require xemacs-lua) * %check is not present; I did not test this package. * owns the directories it creates (ignoring dependency errors above) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * no documentation at all to package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review