https://bugzilla.redhat.com/show_bug.cgi?id=2294403 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- This package is APPROVED. "Latest version is packaged" appears in the SHOULD section. I had to answer NO to that, since there is a commit from 17 September 2021 that is not included in this package. This is only a SHOULD, not a MUST, so I'm approving this request. I assume you had some reason for not wanting that commit. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2294403-erlang-hyper/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8570 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: erlang-hyper-0-0.26.20161011git4b1abc4.fc41.x86_64.rpm erlang-hyper-debuginfo-0-0.26.20161011git4b1abc4.fc41.x86_64.rpm erlang-hyper-debugsource-0-0.26.20161011git4b1abc4.fc41.x86_64.rpm erlang-hyper-0-0.26.20161011git4b1abc4.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvksi2ndr')] checks: 32, packages: 4 erlang-hyper.src: E: spelling-error ('cardinality', '%description -l en_US cardinality -> carnality, cardinal') erlang-hyper.src: E: spelling-error ('sqrt', '%description -l en_US sqrt -> sort, sq rt, sq-rt') erlang-hyper.x86_64: E: spelling-error ('cardinality', '%description -l en_US cardinality -> carnality, cardinal') erlang-hyper.x86_64: E: spelling-error ('sqrt', '%description -l en_US sqrt -> sort, sq rt, sq-rt') erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_array.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_array.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_binary.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_binary.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_binary_rle.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_binary_rle.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_carray.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_carray.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_const.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_const.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_gb.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_gb.erl erlang-hyper.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/hyper-0/ebin/hyper_register.beam /builddir/build/BUILD/erlang-hyper-0-build/hyper-4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_register.erl ========== 4 packages and 0 specfiles checked; 4 errors, 8 warnings, 16 filtered, 4 badness; has taken 0.4 s =========== Rpmlint (debuginfo) ------------------- Checking: erlang-hyper-debuginfo-0-0.26.20161011git4b1abc4.fc41.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2o2lpjs8')] checks: 32, packages: 1 =========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_make_int (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_inspect_binary (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_make_new_binary (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_get_list_length (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_make_double (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_get_uint (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_alloc_resource (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_release_resource (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_get_resource (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_make_badarg (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_make_resource (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_open_resource_type (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so enif_get_list_cell (/usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so) erlang-hyper.x86_64: E: spelling-error ('cardinality', '%description -l en_US cardinality -> carnality, cardinal') erlang-hyper.x86_64: E: spelling-error ('sqrt', '%description -l en_US sqrt -> sort, sq rt, sq-rt') 3 packages and 0 specfiles checked; 2 errors, 13 warnings, 13 filtered, 2 badness; has taken 0.4 s Unversioned so-files -------------------- erlang-hyper: /usr/lib64/erlang/lib/hyper-0/priv/hyper_carray.so Source checksums ---------------- https://github.com/GameAnalytics/hyper/archive/4b1abc4284fc784f6def4f4928f715b0d33136f9/hyper-0.tar.gz : CHECKSUM(SHA256) this package : 61220617c764fd238e447106d362afed914f988c927223057cc3710c5ce43c45 CHECKSUM(SHA256) upstream package : 61220617c764fd238e447106d362afed914f988c927223057cc3710c5ce43c45 Requires -------- erlang-hyper (rpmlib, GLIBC filtered): erlang(erl_nif_version) erlang-basho_stats erlang-crypto(x86-64) erlang-erts(x86-64) erlang-kernel(x86-64) erlang-stdlib(x86-64) erlang-stdlib2 libc.so.6()(64bit) rtld(GNU_HASH) erlang-hyper-debuginfo (rpmlib, GLIBC filtered): erlang-hyper-debugsource (rpmlib, GLIBC filtered): Provides -------- erlang-hyper: erlang-hyper erlang-hyper(x86-64) erlang-hyper-debuginfo: debuginfo(build-id) erlang-hyper-debuginfo erlang-hyper-debuginfo(x86-64) erlang-hyper-debugsource: erlang-hyper-debugsource erlang-hyper-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2294403-erlang-hyper/srpm/erlang-hyper.spec 2024-07-03 11:49:53.645273399 -0600 +++ /home/jamesjer/2294403-erlang-hyper/srpm-unpacked/erlang-hyper.spec 2024-06-25 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 26; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global realname hyper %global git_commit 4b1abc4284fc784f6def4f4928f715b0d33136f9 @@ -65,3 +75,71 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jun 26 2024 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.26.20161011git4b1abc4 +- Switch to Rebar3 + +* Wed Jul 19 2023 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.21.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + +* Thu Jan 19 2023 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.20.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + +* Thu Jul 21 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.19.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Wed Jul 20 2022 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.18.20161011git4b1abc4 +- Rebuild for Erlang 25 + +* Thu Jan 20 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.17.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Wed Jul 21 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.16.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Tue Jan 26 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.15.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Sat Aug 01 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.14.20161011git4b1abc4 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.13.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Thu Mar 5 2020 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.12.20161011git4b1abc4 +- Remove ExcludeArch for s390 - we've got a workaround fr rhbz #1770256 + +* Tue Jan 28 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.11.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Tue Nov 12 2019 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.10.20161011git4b1abc4 +- Rebuild for Erlang 22 + +* Wed Jul 24 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.9.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Wed Feb 27 2019 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.8.20161011git4b1abc4 +- Rebuild with noarch deps + +* Thu Jan 31 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.7.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Tue Oct 02 2018 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.6.20161011git4b1abc4 +- Rebuild with noarch deps + +* Fri Jul 13 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.5.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Wed Mar 21 2018 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.4.20161011git4b1abc4 +- Rebuild for Erlang 20 (with proper builddeps) + +* Fri Feb 23 2018 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.3.20161011git4b1abc4 +- Rebuild for Erlang 20 + +* Wed Feb 07 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 0-0.2.20161011git4b1abc4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Tue Aug 22 2017 Peter Lemenkov <lemenkov@xxxxxxxxx> - 0-0.1.20161011git4b1abc4 +- Initial build + +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2294403 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Perl, Ocaml, Python, SugarActivity, PHP, R, Haskell, fonts, Ruby, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2294403 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294403%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
