https://bugzilla.redhat.com/show_bug.cgi?id=2293468 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to wojnilowicz from comment #2) > The spec file unfortunately fails to pass some checks. Details below. > > ===== ISSUES ===== > 1) According to > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_source_files_from_pypi you should not use the pypi source, because it > doesn't contain a license. Could you use > https://github.com/fmoo/python-varint/archive/refs/tags/1.0.2.tar.gz ? It > contains the license. Done. > 2) According to > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation > the documentation should be included. Could you add "%doc README.md"? I don't think this is necessary. This README.md is extremely short (basically a one-line description) and doesn't contain anything useful for users. > 3) There are no tests in your package, so could you change > "%pyproject_buildrequires -t" to "%pyproject_buildrequires"? Done. > 4) According to > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_test_macros one should still run some tests. Could you use > %pyproject_check_import? Added. > 5) According to > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming > the name of built RPM should be python3-varint. In your case it's > python-varint. Could you correct this? Done. > 6) No need to use "Source0:". Could you change it to "Source:"? Done. > 7) You seem to not use "VCS: git:%{url}.git" for anything. Could > you remove it? Removed. New spec URL: https://peter.fedorapeople.org/packages/python-varint.spec New SRPM URL: https://peter.fedorapeople.org/packages/python-varint-1.0.2-1.fc40.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=119904504 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2293468 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293468%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
