https://bugzilla.redhat.com/show_bug.cgi?id=2292522 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to wojnilowicz from comment #3) > 1) Shouldn't the following subpackage: > > %package -n %{name}+x86-devel > Summary: %{summary} > BuildArch: noarch > > be somehow restricted to x86_64, and not be noarch? No, this is not possible. The "-devel" package must be noarch and be available on all architectures, otherwise you get broken dependencies somewhere. We even have special machinery in rust2rpm for crates that only compile on specific architectures (the "supported-arches" setting in rust2rpm.toml) because of this. > At > https://github.com/etemesi254/zune-image/blob/dev/crates/zune-jpeg/README. > md#crate-features it says that this "Enables x86 specific instructions" This should not be an issue according to the README: https://github.com/etemesi254/zune-image/blob/dev/crates/zune-jpeg/README.md#crate-features """ Note that the x86 features are automatically disabled on platforms that aren't x86 during compile time hence there is no need to disable them explicitly if you are targeting such a platform. """ > 2) x86 requires x86_64-v2, x86_64-v3. Wouldn't that be an issue for > x86_64-v1 when used in an application using this as a dependency? That is a good question. It looks like there is code to guard against using instructions on CPUs where they are not available: https://github.com/etemesi254/zune-image/blob/dev/crates/zune-core/src/options/decoder.rs#L451-L456 This should work under most circumstances. The only way this could break (as far as I can tell) would be if 1) zune-jpeg is built without "std" support 2) with "x86" feature enabled *and* 3) the feature in question is available in the environment where the code is compiled but *not* on the machine the code gets executed on. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292522 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292522%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
