https://bugzilla.redhat.com/show_bug.cgi?id=2293636 --- Comment #15 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- (In reply to Debarshi Ray from comment #12) > (In reply to Mikel Olasagasti Uranga from comment #10) > > > Is %{goname} deprecated? I am asking because go2rpm > > doesn't use it. I see that the packaging guidelines > > still use it: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ > > > > Documentation needs some love. > > > > The template was changed here: > > > > https://gitlab.com/fedora/sigs/go/go2rpm/-/commit/ > > 8b6977dbeca1a7e54921bfe08136520a039b279f > > I see, thanks for the reference. > > The commit message says: > "We now hardcode the Name field to the value of goname," > > ... and the changes replace %{goname} with the name unconditionally: > Name: %{goname} > Name: {{ name }} > > So, are we not supposed to use %{goname} in *.spec files anymore? Correct, no need to use goname, name works just fine. > go-rpm-macros doesn't seem to have deprecated it, but I saw this commit: > https://pagure.io/go-rpm-macros/c/39aa1bbc6ad33a3b603d2f2a16ab186c84c2342a > > ... which looks related, but it's not clear to me how. :) Not a macro expert myself, so not sure if something else should be changed. You can try to ask in https://lists.fedoraproject.org/archives/list/golang@xxxxxxxxxxxxxxxxxxxxxxx/ or Fedora Golang room in Matrix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293636 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293636%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
