https://bugzilla.redhat.com/show_bug.cgi?id=2281565 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Officially taking this review. There are some BuildRequires and Requires that don't look like they are actually necessary: """ BuildRequires: elfutils-libelf-devel BuildRequires: zlib-devel BuildRequires: clang Requires: elfutils-libelf Requires: zlib """ Is there a specific reason why you added these? At least the Requires for elfutils-libelf and zlib are unnecessary. Both libraries are dynamically linked, and dependencies on them are generated by RPM automatically. The BuildRequires on elfutils-libelf-devel, zlib-devel and clang might be leftovers from building with vendored sources? The Packages for Rust crates should already pull in zlib-devel etc. (and clang for bindgen) as needed. === Other than that, the package looks good to me! PS: The spec file you added here: https://github.com/Netflix/bpftop/commit/a737971 is only compatible with recent versions of Fedora and RHEL 9 + EPEL, but will not work for building a package on any other RPM-based linux distribution. So I'm not sure how much benefit there is in keeping it in the upstream github repo. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2281565 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281565%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
