[Bug 2293766] Review Request: syncstar - Guest operated service for creating bootable USB storage devices at any community conference kiosk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2293766



--- Comment #21 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> Does this work https://github.com/gridhead/syncstar/pull/51/files#diff-a3e8ef9115f3b29e265db8edabd533ffd69d8025ea7933be3fbc57563bd72066R8-R12 or should I make changes to it? 

This is perfect, thank you

> I have added it for now https://github.com/gridhead/syncstar/pull/51/files#diff-a3e8ef9115f3b29e265db8edabd533ffd69d8025ea7933be3fbc57563bd72066R44-R45 but cannot confirm if it works yet

Ah, so I took a look and the `test` directory is only in the upstream project
on GitHub but the directory is not present in the PyPI tarballs. So you would
have to change the Source0 to use a GitHub URL like this
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
Up to you if you want to do that or not. But please add at least the
%pyproject_check_import


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2293766

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293766%23c21

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux