https://bugzilla.redhat.com/show_bug.cgi?id=2293766 --- Comment #18 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- I don't want to block this longer, so I gave +1. Few notes though. - The package fails to build for F39 so when requesting DistGit branches, it is not worth requesting one for F39 - Above the "License: AGPL-3.0-or-later AND MIT" line, please add a comment explaining what files are under which license. For example, take a look how I do it here https://src.fedoraproject.org/rpms/python-pywayland/blob/rawhide/f/python-pywayland.spec . Please do this as soon as possible. - Please add a %check section to run unittests or at least for running %pyproject_check_import. Please see the the same specfile as above for an example ^^ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293766 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293766%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
