https://bugzilla.redhat.com/show_bug.cgi?id=2291289 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 The SPDX license name is given in linenoise.opam. - This package bundles the linenoise library, which is available in Fedora. Can it be unbundled? See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling - The ocaml-odoc BuildRequires is not used. Either remove it (which is my recommendation), or build and package the documentation. - The minimum version numbers for the ocaml and ocaml-dune BuildRequires do not match those given in linenoise.opam. Is there some reason for the discrepancy? - The Summary is too long; see the summary-too-long rpmlint warning below. Something like "OCaml bindings to linenoise" is probably sufficient. - Please wrap the text in %description at about 72 characters. See the description-line-too-long rpmlint warning below. - OCaml packages are not built for 32-bit x86 any more. All current OCaml spec files contain these two lines: # OCaml packages not built on i686 since OCaml 5 / Fedora 39. ExcludeArch: %{ix86} - Please ask upstream to include a license file in future release tarballs. - Version 1.5.1 has been released. Please update. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-Clause License", "BSD 2-Clause License". 13 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2291289-ocaml- linenoise/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2309 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ocaml-linenoise-1.5-1.fc41.x86_64.rpm ocaml-linenoise-devel-1.5-1.fc41.x86_64.rpm ocaml-linenoise-debuginfo-1.5-1.fc41.x86_64.rpm ocaml-linenoise-debugsource-1.5-1.fc41.x86_64.rpm ocaml-linenoise-1.5-1.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn27uh947')] checks: 32, packages: 5 ocaml-linenoise.src: E: summary-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml ocaml-linenoise.x86_64: E: summary-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml ocaml-linenoise-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/linenoise/liblinenoise_stubs.a ocaml-linenoise-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/linenoise/linenoise.a ocaml-linenoise.src: E: spelling-error ('readline', 'Summary(en_US) readline -> breadline, deadline, headline') ocaml-linenoise.src: E: spelling-error ('readline', '%description -l en_US readline -> breadline, deadline, headline') ocaml-linenoise.x86_64: E: spelling-error ('readline', 'Summary(en_US) readline -> breadline, deadline, headline') ocaml-linenoise.x86_64: E: spelling-error ('readline', '%description -l en_US readline -> breadline, deadline, headline') ocaml-linenoise-devel.x86_64: W: no-documentation ocaml-linenoise.src: E: description-line-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml ocaml-linenoise.x86_64: E: description-line-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml ========= 5 packages and 0 specfiles checked; 10 errors, 1 warnings, 27 filtered, 10 badness; has taken 0.5 s ========== Rpmlint (debuginfo) ------------------- Checking: ocaml-linenoise-debuginfo-1.5-1.fc41.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfdp6yn2h')] checks: 32, packages: 1 ========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.1 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs camlStdlib__Sys__Pmakeblock_419 (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_named_value (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs camlStdlib__Callback.register_8 (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_stat_free (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs camlStdlib__Callback.register_exception_16 (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_c_call (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_callback2 (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_call_realloc_stack (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_leave_blocking_section (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_alloc (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_alloc1 (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_enter_blocking_section (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_raise_constant (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_initialize (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_call_gc (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_modify (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_bad_caml_state (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_copy_string (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_stat_strdup (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_callback (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/linenoise/linenoise.cmxs caml_state (/usr/lib64/ocaml/linenoise/linenoise.cmxs) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_named_value (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_stat_free (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_callback2 (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_leave_blocking_section (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_alloc (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_enter_blocking_section (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_raise_constant (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_modify (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_bad_caml_state (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_copy_string (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_stat_strdup (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_callback (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: W: undefined-non-weak-symbol /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so caml_state (/usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so) ocaml-linenoise.x86_64: E: summary-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml ocaml-linenoise-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/linenoise/liblinenoise_stubs.a ocaml-linenoise-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/linenoise/linenoise.a ocaml-linenoise.x86_64: E: spelling-error ('readline', 'Summary(en_US) readline -> breadline, deadline, headline') ocaml-linenoise.x86_64: E: spelling-error ('readline', '%description -l en_US readline -> breadline, deadline, headline') ocaml-linenoise-devel.x86_64: W: no-documentation ocaml-linenoise.x86_64: E: description-line-too-long Self-contained OCaml bindings to linenoise, easy high level readline functionality in OCaml 4 packages and 0 specfiles checked; 6 errors, 35 warnings, 25 filtered, 6 badness; has taken 0.7 s Unversioned so-files -------------------- ocaml-linenoise: /usr/lib64/ocaml/stublibs/dlllinenoise_stubs.so Source checksums ---------------- https://github.com/ocaml-community/ocaml-linenoise/archive/v1.5/linenoise-v1.5.tar.gz : CHECKSUM(SHA256) this package : fb414e04def9ff529821c61513c225298769999dd9d70477a3c2740e2b9cc334 CHECKSUM(SHA256) upstream package : fb414e04def9ff529821c61513c225298769999dd9d70477a3c2740e2b9cc334 Requires -------- ocaml-linenoise (rpmlib, GLIBC filtered): libc.so.6()(64bit) ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__Callback) ocaml(Stdlib__Sys) rtld(GNU_HASH) ocaml-linenoise-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__Callback) ocaml(Stdlib__Sys) ocaml-linenoise(x86-64) ocamlx(Stdlib__Callback) ocamlx(Stdlib__Sys) ocaml-linenoise-debuginfo (rpmlib, GLIBC filtered): ocaml-linenoise-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-linenoise: ocaml(LNoise) ocaml-linenoise ocaml-linenoise(x86-64) ocaml-linenoise-devel: ocaml(LNoise) ocaml-linenoise-devel ocaml-linenoise-devel(x86-64) ocamlx(LNoise) ocaml-linenoise-debuginfo: debuginfo(build-id) ocaml-linenoise-debuginfo ocaml-linenoise-debuginfo(x86-64) ocaml-linenoise-debugsource: ocaml-linenoise-debugsource ocaml-linenoise-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2291289-ocaml-linenoise/srpm/ocaml-linenoise.spec 2024-06-29 07:59:20.652282539 -0600 +++ /home/jamesjer/2291289-ocaml-linenoise/srpm-unpacked/ocaml-linenoise.spec 2024-05-01 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: ocaml-linenoise Version: 1.5 @@ -41,3 +51,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Thu May 02 2024 U2FsdGVkX1 <U2FsdGVkX1@xxxxxxxxx> - 1.5-1 +- first commit +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2291289 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ocaml, Shell-api, C/C++ Disabled plugins: Perl, Java, Python, SugarActivity, Haskell, PHP, Ruby, fonts, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2291289 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291289%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
