https://bugzilla.redhat.com/show_bug.cgi?id=2294337 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u clean-rpm-gpg-pubkey.spec{.old,} --- clean-rpm-gpg-pubkey.spec.old 2024-06-25 23:19:48.000000000 +0200 +++ clean-rpm-gpg-pubkey.spec 2024-06-26 18:05:46.000000000 +0200 @@ -7,16 +7,16 @@ Version: 0 Release: %{autorelease} Summary: Remove old PGP keys from the RPM database -License: GPL-3.0-only +License: GPL-3.0-only URL: %{forgeurl} Source: %{forgesource} BuildArch: noarch -BuildRequires: perl BuildRequires: perl-generators Requires: /usr/bin/curl Requires: /usr/bin/gpg2 Requires: /usr/bin/rpm +Requires: fedora-release-common Requires: fedora-repos %{?perl_default_filter} @@ -39,6 +39,7 @@ %files %doc README.md +%license COPYING %license COPYING.GPL %{_bindir}/%{name} $ rpmlint clean-rpm-gpg-pubkey.spec ../SRPMS/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.src.rpm ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 clean-rpm-gpg-pubkey.noarch: W: no-manual-page-for-binary clean-rpm-gpg-pubkey clean-rpm-gpg-pubkey.spec: W: no-%build-section clean-rpm-gpg-pubkey.spec: W: no-%build-section === 2 packages and 1 specfiles checked; 0 errors, 3 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm -rwxr-xr-x 1 root root 2952 Jun 27 02:00 /usr/bin/clean-rpm-gpg-pubkey drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/doc/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 812 May 5 2021 /usr/share/doc/clean-rpm-gpg-pubkey/README.md drwxr-xr-x 2 root root 0 Jun 27 02:00 /usr/share/licenses/clean-rpm-gpg-pubkey -rw-r--r-- 1 root root 70 May 5 2021 /usr/share/licenses/clean-rpm-gpg-pubkey/COPYING -rw-r--r-- 1 root root 35147 May 5 2021 /usr/share/licenses/clean-rpm-gpg-pubkey/COPYING.GPL File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm | sort -f | uniq -c 1 /usr/bin/curl 1 /usr/bin/gpg2 1 /usr/bin/perl 1 /usr/bin/rpm 1 fedora-release-common 1 fedora-repos 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(IO::File) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/clean-rpm-gpg-pubkey-0-1.20210505gitebb9ab1.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package build in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=119683282). The package is in-line with Fedora packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2294337 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294337%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
