https://bugzilla.redhat.com/show_bug.cgi?id=2293636 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mikel@xxxxxxxxxxxxxxx --- Comment #3 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > I chose to disable the tests by default because a few of them require the presence of the proprietary NVIDIA driver. Can add this as a comment before the bcond_with? > The Git tags and versions used by upstream (eg., v0.12.4-0) are not valid RPM versions because they contain a dash. That's why I chose to define '%tag' and left the %version as 0. What a strange way to version the package. One option would be to use: Version: 0.12.4.0 %global tag v0.12.4-0 WDYT? You'll need to generate the package with `go2rpm -q github.com/NVIDIA/go-nvml -t v0.12.4-0` and modify the Version entry. > The generated Provides don't have 'golang(github.com/NVIDIA/go-nvml)'. I hope that's alright because the top-level source directory doesn't have any Go sources. So, users of this module need to import the sub-paths. It's correct and not an issue. If you check the example in the README file you'll see they're not using top-level dir, but the whole path as expected: https://github.com/NVIDIA/go-nvml/blob/main/README.md?plain=1#L59 On top of these changes, would it be possible to update to latest go2rpm (1.12.0) package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293636 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293636%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
