https://bugzilla.redhat.com/show_bug.cgi?id=1686307 --- Comment #31 from Adam Williamson <awilliam@xxxxxxxxxx> --- Cool, that looks a lot better. As a nitpick, shouldn't 0008-Avoid-using-sys.prefix-in-CLI-test.patch be up with the "Fedora-specific" patches? It doesn't really look upstreamable. Or if you think upstream might take it, it should have a PR link :) But regardless, I'd say this is now approved. For the one test that failed on the COPR build we could patch that time limit to 4 seconds, or just rely on spamming builds, I guess. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1686307 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201686307%23c31 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
