https://bugzilla.redhat.com/show_bug.cgi?id=2292255 --- Comment #11 from Carl George 🤠 <carl@xxxxxxxxxx> --- Your license expression needs some adjustments. At one point it has "AND AND", which results in an rpmlint warning. You have a couple of duplicative OR sub-expressions that are the same thing in a different order. - (MIT OR Apache-2.0) - (Apache-2.0 OR MIT) - (MIT OR BSD-3-Clause OR Apache-2.0) - (BSD-3-Clause OR Apache-2.0 OR MIT) You can actually drop the OR sub-expressions that already fully covered by the other licenses outside the sub-expressions. https://docs.fedoraproject.org/en-US/legal/license-field/#_special_rules_for_or_expressions Based on the guidelines, this should be the correct license tag, although you may want to look closer into that "AND AND" string to make sure no licenses were missed. License: 0BSD AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND GPL-3.0-or-later AND ISC AND MIT AND MPL-2.0 AND (Apache-2.0 OR CC-BY-SA-4.0) AND (BSD-2-Clause-Views OR BSD-3-Clause) ================================================================================ You still have cmd/tailscale/cli/licenses.go included as a %license file. It isn't a license file, it's a source file related to the licenses subcommand. It needs to be removed. ================================================================================ There is still irrelevant documentation included. At a minimum, docs/sysv/ and docs/windows/ are definitely not relevant and need to be removed. I'll leave it up to you if derp/README.md, docs/bird/, docs/k8s/, and docs/webhooks/ are relevant enough to be included (my guess is no). ================================================================================ %gopkginstall is in both %build and %install. It should only be in %install. On a related note, the %gobuild commands in %build are inside an %else that will cause them to not be run if you ever disable the vendor conditional. That %else conditional should be removed so that the %gobuild commands always run. ================================================================================ In your unit file, you're referencing /usr/sbin/tailscaled, but you're installing the command as /usr/bin/tailscaled. These should match. Considering the upcoming change to unify /usr/bin and /usr/sbin, the best course of action would be to change the unit file to match /usr/bin/tailscaled. https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin ================================================================================ Is there a purpose to commenting out the GOPROXY line instead of removing it, along with the corresponding comments? ================================================================================ What is the benefit of specifying PORT and FLAGS as environment variables in the unit file? Now that you dropped the sysconfig file, they seem pointless to me. Since a user has to create a unit file override to modify them, they can just edit the ExecStart line directly at that point. For simplicity, I think this should just be: ExecStart=/usr/bin/tailscaled --state=/var/lib/tailscale/tailscaled.state --socket=/run/tailscale/tailscaled.sock --port=41641 ================================================================================ Currently the %check section is not being run. It is tied to whether or not you are doing a vendored build. In theory the tests should be able to be run regardless of whether you're doing a vendored build or not. Try to run these if you can get them to pass. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2292255 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292255%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
