[Bug 1686307] Review Request: python-distributed - Distributed scheduler for Dask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1686307

Adam Williamson <awilliam@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |awilliam@xxxxxxxxxx



--- Comment #17 from Adam Williamson <awilliam@xxxxxxxxxx> ---
so, status on remaining fails...

* the 0.0.0.0 vs. 127.0.0.1 stuff (#2554) should be fixed by
https://github.com/dask/distributed/pull/8712
* the deeply_nested_structures thing seems to be just a test making unsafe
assumptions about when and how things will fail -
https://github.com/dask/distributed/issues/8700 . we could possibly write a
better test, I've floated an idea along those lines in the issue, but I think
it's fine to disable it for now
* the test_upload_file_zip thing seems to be due to a recent change in cpython
zipimport: https://github.com/python/cpython/pull/103208 . I found a way to fix
it in cpython:
https://github.com/python/cpython/pull/103208#issuecomment-2181682479 . gonna
see if we get feedback from upstream to decide how to proceed there
* test_git_revision should be fixed by
https://github.com/dask/distributed/pull/8709 , I think I saw a version of the
spec with that fixed?

overall I think we're good enough to ship this, honestly. Will take a step back
and give the spec a general review later or tomorrow.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1686307

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201686307%23c17
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux