https://bugzilla.redhat.com/show_bug.cgi?id=2291346 --- Comment #10 from Cristian Le <fedora@xxxxxxxxx> --- (In reply to wojnilowicz from comment #9) > (In reply to Cristian Le from comment #8) > > > I don't target EPEL9. Do you have any source of that information? > > > > Personal experience [1,2]. > > It seems to me that you're referring to a deprecated versioning scheme > described at It's not that, it's related to `setuptools_scm` not working properly on EPEL9. It doesn't apply in this case, but I mainly mention this because there can be subtle differences, which can help minimizes surprises down the line. Ultimately as you will be maintaining it and have more experience with the project and ecosystem, I will leave it to your call which source to use. --- One thing I will push back on is the use of commit for packaging. It is not mentioned clearly in the packaging guidelines, but it is partially covered in the review template ===== SHOULD items ===== Generic: [ ]: Latest version is packaged. In the case of `loguru` that you have pointed, it is more justified because: - It is a C++ project so there are no standard package repos like PyPI to consider - The package was initially submitted for review in 2024, but there are no tags/releases since 2019, despite an open issue of that [1], despite a major feature of CMake support being added [2] In this project, the release schedule seems relatively healthy, it is still in active development, and I don't see an issue requesting tagging a new version. Comparing the changes to the main branch [3], I don't see any relevant commits that would justify not using the published version. --- I understand that you have reservations on this since it is not formally stated in the packaging guidelines, so by all means, ask for a second opinion. And if you find the packaging guidelines are a bit ambiguous on certain topics, feel free to raise issues and suggestions on it (top-right corner on a page). You can see that these guidelines are constantly evolving. [1]: https://github.com/emilk/loguru/issues/239 [2]: https://github.com/emilk/loguru/pull/215 [3]: https://github.com/ActivityWatch/aw-client/compare/v0.5.13...master -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2291346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291346%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
