https://bugzilla.redhat.com/show_bug.cgi?id=2263790 Martin Hoyer <mhoyer@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(fedora@xxxxxxxxx) | |needinfo?(mhroncok@redhat.c | |om) CC| |mhroncok@xxxxxxxxxx --- Comment #32 from Martin Hoyer <mhoyer@xxxxxxxxxx> --- > What is meant by srcforge if github.com is not one of them? You're assigning `%global srcforge https://github.com/kislyuk/yq`. I'd expect such variable name to be pointing to sourceforge vcs. Am I missing something? >I have modified it to use just alternatives Ack. >Patch is actually more safe Ack. @fedora@xxxxxxxxx Do you want to take this review? I'm not in love with the idea of doing `-alt`, but feel like this whole thing is way over my head and don't want to block things unnecessarily. @mhroncok@xxxxxxxxxx Any chance you could take a quick look, pretty please? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2263790 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263790%23c32 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue