https://bugzilla.redhat.com/show_bug.cgi?id=2291346 --- Comment #7 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Cristian Le from comment #6) > > For me it would mean extra work for no advantage. Why would you like that? > > If the project moves to dynamic-version, the PyPI source is guaranteed to > work. Currently EPEL9 does not work with dynamic versioning even when > `.git_archival.txt` is included appropriately. I don't target EPEL9. Do you have any source of that information? At https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_handling_non_sorting_versions_with_tilde_dot_and_caret I can only find that it wouldn't be compatible with EPEL7. > > As for the tags, they are there but no zip releases. Following a git seems to be most flexible, especially that other packages from this author can be tracked by git commit only. > > You have git archives, e.g.: > https://github.com/ActivityWatch/aw-client/releases/tag/v0.5.13 Oh. I didn't know it. Thanks. On one hand it would be good to have 0.5.13 but on the other there are some fixes like this one https://github.com/ActivityWatch/aw-client/commit/7e12bf2c9727b6abba01e36669c04ebc69b5c89a that appear at random across whole ActivityWatch and might not be included in the last point release. If you don't mind, I would stick with git. > If you want it to be more flexible, than how about forge_meta [1]? I don't know forge_meta. Git seems to be easy enough and flexible for me. The Packaging Guideline is also fine with this. > > I'm not sure. I've never did that. I don't want to go down on strange errors because the author tested it on aw-server and I did that on aw-server-rust and something doesn't pass the test. > > Well even with that, the author chose to use `input()` to block the > automated testing so it's rather hard to implement regardless. Hopefully > there are other projects that can do integration tests for it, or just > cross_fingers and test live on users :D. > > [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Oh. I see. Rocket crates are no better. They're not cut clean for testing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2291346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291346%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
