https://bugzilla.redhat.com/show_bug.cgi?id=2291346 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | --- Comment #3 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Cristian Le from comment #2) > Some remarks: > > Are the sed commands necessary? > ``` > sed -r -i '/^[[:blank:]]*pytest-cov\b/d' pyproject.toml > sed -r -i '/^[[:blank:]]*pylint\b/d' pyproject.toml > sed -r -i '/^[[:blank:]]*black\b/d' pyproject.toml > ``` > These seem to be used only in dev dependency, but you manually add `pytest` > to it. Otherwise types-* should also be excluded, along with everything else > frankly. Actually not. As far as I can see no linter is run in %check when I removed those lines. I've updated the .spec file > I'm not a fan of `%{srcname}`, but only `%{_bindir}/%{srcname}` in > particular should be changed because there is generally no connection > between those. Replaced `%{_bindir}/%{srcname}` with `%{_bindir}/aw-client`. > Can you explain the choice for using the git commit and/or link to some > discussion upstream on it? A GitHub release is stuck at 0.5.9 but the source code is already at 0.5.13, so I choosen to follow git. > --- > > Other than that LGTM. Would have preferred more tests to be run since the > available tests are quite barren, even if they would need to be run outside > of package build, but the `input()` would be a bit tricky to deal with. Not sure if that would be possible. At first look the tests in this package require aw-server which I'm not going to even package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2291346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291346%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
