https://bugzilla.redhat.com/show_bug.cgi?id=2291345 --- Comment #5 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Cristian Le from comment #4) > > BTW, you forgot to assign yourself to this bug? > > Thanks, didn't know the changing the status didn't change that as well. No problem. I forgot it once too :) > > I cannot attach an empty file here. > > Sorry, I wanted to say to add it in the final repo. Ok. > > I'm not sure how an empty file would be useful here. I don't see it in other approved packages. Could you elaborate? > > Not common, but it helps indicate that a default rust2rpm was used, and if > this changes in future package bumps, than it can help keep track of that > change. Technically the changes of the license files could be added in the > `rust2rpm.toml` minus addressing the FIXME part, but maybe not worth it > since it's already merged. Could you relax on that requirement? I see a similar package committed recently at https://src.fedoraproject.org/rpms/rust-zune-core It also adds the licenses missing in the crate and no empty rust2rpm.toml there. I just don't want to do any extra work and stand out from what proven packagers package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2291345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291345%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
