https://bugzilla.redhat.com/show_bug.cgi?id=2291345 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED --- Comment #2 from Cristian Le <fedora@xxxxxxxxx> --- LGTM, the default `rust2rpm` was used and just tweaked the license files. Should be resolved in the next release. Could you include an empty `rust2rpm.toml` just to inform others that the default was used thus far? --- (template review mixed from Robert and Fabio) Package was generated with rust2rpm, simplifying the review. [x] The latest version is packaged or packaging an earlier version is justified. [x] The License tag reflects the package contents and uses the correct identifiers. [x] The package builds successfully in mock. [x] Package is installable (checked by fedora-review). [x] There are no relevant rpmlint errors. [x] The package runs tests in %check. [x] The package's binaries don't conflict with binaries already in the distribution. [x] There are no %{_bindir}/* wildcards in %files. [x] The package complies with the Rust and general Packaging Guidelines. --- Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2291345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202291345%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue