[Bug 2208353] Review Request: python-unicode-slugify - Slug generator that turns strings into unicode slugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2208353

Cristian Le <fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxx



--- Comment #7 from Cristian Le <fedora@xxxxxxxxx> ---
> License needs clarification, ambiguity with between spec file and upstream.

If I understand correctly you are referring to the pypi showing BSD and spec
BSD-3-clause. Comparing BSD-3-clause [1] with LICENSE, it seems the latter is
correct. But please make a patch to fix the metadata.

But unicode projects seem to very tricky w.r.t. licensing. Afaics, it doesn't
use any unicode licensed data, so it should be fine with the current license
metadata. The "Unknown or generated" part should be fine since if you look at
the whole project, there isn't much there.

> It's not clear what is being packaged. The package depends on python3-slugify

Actually it doesn't, but it should be marked as `Conflicts`/`Obsoletes` since
python3-slugify is effectively dead. Here are some affected packages:
```console
$ fedrq wr --branch=rawhide python3-slugify
python-agate-1.11.0-1.fc41.src
python-cookiecutter-2.6.0-2.fc41.src
python-django-uuslug-2.0.0-9.fc41.src
python3-agate-1.11.0-1.fc41.noarch
python3-cookiecutter-2.6.0-2.fc41.noarch
python3-django-uuslug-2.0.0-9.fc41.noarch
transifex-client-0.13.7-15.fc41.noarch
transifex-client-0.13.7-15.fc41.src
```

> The upstream sources for the package seem to only contain a test suite

It also includes `__init__.py` which I think is what's meant to be the main
thing packaged. As for having `tests` inside the main package, that is a rather
common pattern, even though I personally don't like it.


[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux