https://bugzilla.redhat.com/show_bug.cgi?id=2254709 --- Comment #17 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- > - Add RUNPATH pointing to %%{_libdir}/shotc I think you cut the changelog line short above. It runs fine now, however: $ rpm -q --provides shotcut|grep Cute libCuteLogger.so()(64bit) $ rpm -qR shotcut|grep Cute libCuteLogger.so()(64bit) Please filter this internal library out from Provides: and Requires:, for example by adding: %global __provides_exclude_from ^%{_libdir}/%{name}/libCuteLogger\\.so %global __requires_exclude ^libCuteLogger\\.so See https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/ for more details. > # The entire source code is GPLv3+ The comment is wrong now, change it to, for example, "# Main code is GPLv3+" or drop entirely. > License: GPL-3.0-or-later AND LGPL-2.1-or-later AND Apache-2.0 AND MIT As I mentioned earlier, CuteLogger is LGPL2-2.1-only. Please correct the license string. Other than that, it looks good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254709 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254709%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
